Closed
Bug 1004542
Opened 10 years ago
Closed 10 years ago
Back key remains selected when pressed in Music app to transition from PlayerView to SubListView
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(feature-b2g:2.0, tracking-b2g:backlog, b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S3 (6june)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | fixed |
People
(Reporter: nsarkar, Assigned: dkuo)
References
Details
(Whiteboard: [caf priority: p3][cr 655296] [priority])
Attachments
(4 files)
STR: 1. Go to Music app->Playlist->Most played. 2. Click on a song. It starts playing. 3. Click on back button. 4. We go back to the Most played screen. But the back key is still selected. Expected UI behavior: back key should not be selected when we go back to the Most played playlist screen. Note: When I put the music app in the background or press the home key, the screen gets refreshed and back key is not selected anymore. It seems like a simple screen transition issue.
Summary: Back key remains selected when pressed to transition from PlayerView to SubListView → Back key remains selected when pressed in Music app to transition from PlayerView to SubListView
This issue DOES reproduce on 1.3 1.3 Environmental Variables: Device: Buri BuildID: 20140501053808 Gaia: 667539f1ed4becc45b182a5f1046221d3eeb9e7c Gecko: f3601c4c3d59 Version: 28.0 Firmware Version: v1.2-device.cfg
Keywords: qawanted
Assignee | ||
Comment 3•10 years ago
|
||
Nivi, would you please also attach the screenshot? I think it's probably caused by the visual/css changes, thanks.
Flags: needinfo?(nsarkar)
Note that the back key is still selected when we go back to the Playlist screen.
Comment 7•10 years ago
|
||
Don't think this is a blocker for 1.4 but definitely a nice to have and improve our quality. :dkuo can you fix this for 2.0 ?
blocking-b2g: 1.4? → 2.0?
Assignee | ||
Comment 8•10 years ago
|
||
yes, and first I can see if it reproduces on master, it should be caused by css or gecko changes so will take some time to find the root cause, but probably already fixed since gecko is always changing.
Flags: needinfo?(dkuo)
Comment 9•10 years ago
|
||
Putting this in non-blocking but priority bucket.
blocking-b2g: 2.0? → backlog
Whiteboard: [cr 655296] → [cr 655296] [priority]
Updated•10 years ago
|
Blocks: CAF-v2.0-FC-metabug
Comment 10•10 years ago
|
||
We have a music app refresh (next major revision) that is being planned soon with features like playlists. Jim, If this is a simple fix, lets try to get the fix in for 2.0 (dominic suspects that it could be a gecko issue too). Also just a note that headers with back key navigation is possibly being updated as part of visual refresh (need to confirm for music app)
Flags: needinfo?(squibblyflabbetydoo)
Target Milestone: --- → 2.0 S4 (20june)
Comment 11•10 years ago
|
||
possibly related to: https://bugzilla.mozilla.org/show_bug.cgi?id=995532
Comment 12•10 years ago
|
||
Probably the same bug as 988086. I don't think either one is a media bug, but I don't know who should be looking at it. System team?
Comment 13•10 years ago
|
||
Yeah, I've been seeing this stuff all over Gaia (the settings app is another big one). I really think it's a Gecko bug.
Flags: needinfo?(squibblyflabbetydoo)
Updated•10 years ago
|
Target Milestone: 2.0 S4 (20june) → ---
Assignee | ||
Comment 14•10 years ago
|
||
Found a workable patch and I am working on it.
Assignee: nobody → dkuo
Flags: needinfo?(dkuo)
Assignee | ||
Comment 15•10 years ago
|
||
Arnau, I have found the back key remains selected/highlighted is because the :focus style, and looks like it inherits the :hover/:active(probably a gecko issue?) style so after we pressed the back button, it gets focused and :focus style will be applied. My patch is to add the :focus styles individually to all the headers then force the background-color to be same as the header's, but not sure if it's a right approach since it modified all the header's style in the building block, would you please comment on this? thanks.
Attachment #8430117 -
Flags: feedback?(arnau)
Comment 16•10 years ago
|
||
Recently there were some issues with :active but I think they're fixed now. In https://bugzilla.mozilla.org/show_bug.cgi?id=995532#c15 I said: "kats says bug 1013378 should fix most of the recent :active bustage (likely regressed by bug 964750)." If things are still broken, I recommend getting kats and botond involved and perhaps moving the bug to Core::Panning and Zooming.
Comment 17•10 years ago
|
||
(In reply to Andrew Overholt [:overholt] from comment #16) > Recently there were some issues with :active but I think they're fixed now. > In https://bugzilla.mozilla.org/show_bug.cgi?id=995532#c15 I said: "kats > says bug 1013378 should fix most of the recent :active bustage (likely > regressed by bug 964750)." > > If things are still broken, I recommend getting kats and botond involved and > perhaps moving the bug to Core::Panning and Zooming. Let me re-confirm with QA if this is reproducible still on 2.0, given the landing 1013378 a few days back which may have helped this issue as :overholt recommends.
Flags: needinfo?(jharvey)
Keywords: qawanted
Dominic, the :focus idea to block :hover effect works great! Could you please replace the selected color in your patch with `transparent`? This way we won't have to update it in case we are changing a header background-color. We would also need that fix in web components. Could you please add the focus state in shared/elements/gaia_header/style.css? (every time you see a :hover) Please add me as a reviewer when you update your patch :)
Comment 19•10 years ago
|
||
Attempting to reproduce the issue using the STRs causes a crash on the latest Central Buri build upon playing a song in the Most played screen. Environmental Variables: Device: Buri BuildID: 20140529075050 Gaia: b669dd2cc321f37cebc7081a79b968cac36b4200 Gecko: a3848fbadb16 Version: 32.0a1 Firmware Version: v1.2-device.cfg Crash report: https://crash-stats.mozilla.com/report/index/ee7c4f30-ba55-4744-bb4f-65f222140529
Flags: needinfo?(jharvey)
Keywords: qawanted
Comment 20•10 years ago
|
||
Can we try testing this on Flame on 2.0? There's no crash symbols in that report...
Keywords: qawanted
Attachment #8430117 -
Flags: feedback?(arnau)
Assignee | ||
Comment 21•10 years ago
|
||
Comment on attachment 8430117 [details]
Add :focus styles to the BB headers
Arnau, I have changed the :focus background-color to transparent, also added the styles to the web component headers, would you please take a look on the patch again? thanks.
Attachment #8430117 -
Flags: review?(arnau)
Assignee | ||
Updated•10 years ago
|
Component: Gaia::Music → Gaia
Comment on attachment 8430117 [details]
Add :focus styles to the BB headers
Works Great! Thanks Dominic.
Please squash your commits before landing.
Attachment #8430117 -
Flags: review?(arnau) → review+
Updated•10 years ago
|
Whiteboard: [cr 655296] [priority] → [caf priority: p3][cr 655296] [priority]
Comment 23•10 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #20) > Can we try testing this on Flame on 2.0? There's no crash symbols in that > report... This issue DOES still reproduce on the latest flame 2.0 2.0 Environmental Variables: Device: Flame 2.0 BuildID: 20140604064615 Gaia: a38a6a5c6fabc97dd16d5360632b5ac5c7e06241 Gecko: c7fdd7e755cd Version: 32.0a1 Firmware Version: v10G-2
Keywords: qawanted
Updated•10 years ago
|
feature-b2g: --- → 2.0
Assignee | ||
Comment 24•10 years ago
|
||
It might be the gecko issue that Andrew mentioned in comment 16, but since the gaia patch won't harm the headers and added the :focus styles(which is better and safer for the buttons when they are focused), so I am going to land it without waiting/finding the gecko fix.
Assignee | ||
Comment 25•10 years ago
|
||
Landed on master: a98a7a3bb570c893c07afeab52546fd3f67e30bb
Updated•10 years ago
|
Target Milestone: --- → 2.0 S3 (6june)
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•