John Keiser (jkeiser) Reporter
	Description • 23 years ago

When you set document.mainform.x.name = "y"; and then do
alert(document.mainform.x.name); it will show up as "y".  This means we can
still access the element by its old name.

In the URL, click "name", "(set)", and then "name" again on any of the selects.
 The fact that the "name" succeeds illustrated the problem.

	Johnny Stenback (:jst)
	Comment 2 • 23 years ago

The fix for this is to simply not define form.foo when 'foo' is resolved on the
form, doing that didn't really give us anything since we do the real work in
::GetProperty() in the helper.

jband, sr=?

	Johnny Stenback (:jst)
	Comment 3 • 23 years ago

Hmm, never mind, the attached patch isn't quite right.

	Johnny Stenback (:jst)
	Comment 7 • 23 years ago

jband, brendan, r/sr=?

	Fabian Guisset
	Comment 8 • 23 years ago

before checking in the patch (which looks good), would it be possible to fix the
large comment so that the first sentence is easier to understand (is there a
missing word?) and also the typo fomr->form.
Thanks.

	Brendan Eich [:brendan]
	Comment 9 • 23 years ago

"the form objects prototype chain" needs an apostrophe in "objects".

The MozillaClassic DOM level 0 code took no steps to remove the old name.  Does
IE?  Just curious.

Is there an alternative where you remove the old name in the setter for the name
property?  Might that be simpler (no anti-recursion required)?

/be

	Johnny Stenback (:jst)
	Comment 11 • 23 years ago

Eh, hmm, ignore the above, wrong bug...

	Johnny Stenback (:jst)
	Comment 12 • 23 years ago

Brendan, looks like IE has the same bug. I'm actually not that worried about
formcontrols being reachable by their old name, but the fact that the old name
will shadow a new form control that is inserted with the old name is
unfortunate. Interestingly enough, IE has the same problem. Given that, I'll
move this to mozilla1.0 and we'll decide what to do later on...

	Asa Dotzler [:asa]
	Comment 13 • 23 years ago

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

	Johnny Stenback (:jst)
	Comment 14 • 22 years ago

Mass-reassigning bugs.

	Boris Zbarsky [:bzbarsky]
	Comment 15 • 11 years ago

Looks like browsers interoperably do this, and the spec requires it.  See the past names map.