:Irving Reid (No longer working on Firefox) Assignee
	Description • 10 years ago

The xpcshell run_next_test() method starts the next async test case on a future spin of the event loop, but the mochitest version of run_next_test() is synchronous.

We should change the mochitest run_next_test so that it yields to the event loop before starting the next test, and also while we're at it, port the code from bug 972093 that detects calls to run_next_test() from add_task() style tests.

	(no longer active)
	Comment 1 • 10 years ago

What is the mochitest run_next_test function?

	:Irving Reid (No longer working on Firefox) Assignee
	Comment 2 • 10 years ago

Serves me right for not DXRing the heck out of this - it's local to toolkit/mozapps/extensions/test/browser/head.js.

	:Irving Reid (No longer working on Firefox) Assignee
	Comment 3 • 10 years ago

That said, there are parallel implementations of add_test / run_next_test spread all over the tree and several others have the same bug; http://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=%22function%20run_next_test%22&redirect=true

	(no longer active)
	Comment 4 • 10 years ago

(In reply to comment #2)
> Serves me right for not DXRing the heck out of this - it's local to
> toolkit/mozapps/extensions/test/browser/head.js.

lol, np :-)

	:Irving Reid (No longer working on Firefox) Assignee
	Comment 5 • 10 years ago

Also removed a bunch of now-redundant "executeSoon(run_next_test)" wraps.

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 6 • 10 years ago

should we file another bug to fix this for all mochitests?

	Dave Townsend [:mossop]
	Comment 7 • 10 years ago

(In reply to Joel Maher (:jmaher) from comment #6)
> should we file another bug to fix this for all mochitests?

There isn't a global instance for mochitests. We should probably file a bug to make one.

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 8 • 10 years ago

oh bug 1007906

	:Irving Reid (No longer working on Firefox) Assignee
	Comment 9 • 10 years ago

Well, this *was* going to be the "fix it everywhere" bug until I realized that there were multiple implementations...

What Mossop said, with a side order of "I wish it wasn't too much work to change all the tests to be Task-style." I'd rather spend the time moving to a single implementation rather than fixing all the copies.

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 10 • 10 years ago

good_first_bug territory!  Lay the work out, maybe someone on the ateam could pick it up and do a big chunk of it.

	:Irving Reid (No longer working on Firefox) Assignee
	Comment 11 • 10 years ago

I accidentally committed the part where I removed now-redundant executeSoon calls into the wrong patch, they're here now.

	:Irving Reid (No longer working on Firefox) Assignee
	Comment 12 • 10 years ago

https://hg.mozilla.org/integration/fx-team/rev/a05f2483f74b

	Carsten Book [:Tomcat]
	Comment 13 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/a05f2483f74b