Closed
Bug 1009565
Opened 11 years ago
Closed 10 years ago
Triggering arbitrary jobs gets branch wrong
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: zeller)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
catlee
:
review+
hwine
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
hwine
:
review+
hwine
:
checked-in+
|
Details | Diff | Splinter Review |
In http://hg.mozilla.org/build/buildapi/file/default/buildapi/scripts/selfserve-agent.py#l614
we create strip off the "-selfserve" to create real_branch, and refer to that in the SQL query. However, we don't pass real_branch into db.execute(), so :real_branch ends up being unset, and we end up with branch = NULL in the database.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → johnlzeller
Assignee | ||
Comment 1•11 years ago
|
||
Added real_branch to selfserve-agent.py
Attachment #8422027 -
Flags: review?(catlee)
Reporter | ||
Comment 2•11 years ago
|
||
Comment on attachment 8422027 [details] [diff] [review]
bug1009565.patch
Review of attachment 8422027 [details] [diff] [review]:
-----------------------------------------------------------------
itym real_branch=real_branch, since the parameter is called :real_branch
Attachment #8422027 -
Flags: review?(catlee) → review-
Assignee | ||
Comment 3•11 years ago
|
||
Opps! Here you go!
Attachment #8422027 -
Attachment is obsolete: true
Attachment #8422070 -
Flags: review?(catlee)
Reporter | ||
Updated•11 years ago
|
Attachment #8422070 -
Flags: review?(catlee) → review+
Assignee | ||
Updated•11 years ago
|
Attachment #8422070 -
Flags: checked-in?
Comment 4•11 years ago
|
||
Comment on attachment 8422070 [details] [diff] [review]
bug1009565.patch
https://hg.mozilla.org/build/buildapi/rev/8e291c17c8b6
Attachment #8422070 -
Flags: checked-in? → checked-in+
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•11 years ago
|
||
Reopened till deployed. Was prematurely closed
Reporter | ||
Comment 6•10 years ago
|
||
are we waiting for anything before deploying?
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Chris AtLee [:catlee] from comment #6)
> are we waiting for anything before deploying?
Nope! Deploying now
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8431929 -
Flags: review?(hwine)
Comment 9•10 years ago
|
||
Comment on attachment 8431929 [details] [diff] [review]
versionbump.patch
lgtm: r+
https://hg.mozilla.org/build/buildapi/rev/ace9bb8c2267
Attachment #8431929 -
Flags: review?(hwine)
Attachment #8431929 -
Flags: review+
Attachment #8431929 -
Flags: checked-in+
Assignee | ||
Comment 10•10 years ago
|
||
All deployed and tested! Additionally, pending/running jobs are now showing up on TBPL as well. Seems this was the issue effecting bug 981825
Status: REOPENED → RESOLVED
Closed: 11 years ago → 10 years ago
Resolution: --- → FIXED
Comment 11•10 years ago
|
||
That's great - thank you :-)
Assignee | ||
Comment 12•10 years ago
|
||
(In reply to Ed Morley [:edmorley UTC+0] from comment #11)
> That's great - thank you :-)
No problem!
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•