Kevin Grandon :kgrandon Reporter
	Description • 10 years ago

A recent z-index change has made it so that something is over the software home button when first enabling it.

	Kevin Grandon :kgrandon Reporter
	Comment 1 • 10 years ago

Hey guys - got time for a quick review?

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 2 • 10 years ago

Comment on attachment 8424630 [details]
Github pull request

I think the problem here is: why the appWindow is not resized correctly on software button enabled? The overlay should be the same sizing as its appWindow container so I don't think this is a right fix.

	Etienne Segonzac (:etienne) Assignee
	Comment 3 • 10 years ago

Comment on attachment 8424630 [details]
Github pull request

Hum, could this be caused by bug 1011262?

	Kevin Grandon :kgrandon Reporter
	Comment 4 • 10 years ago

(In reply to Etienne Segonzac (:etienne) from comment #3)
> Comment on attachment 8424630 [details]
> Github pull request
> 
> Hum, could this be caused by bug 1011262?

I don't think so. I think it was always there, just surfaced due to the z-index changes in bug 992081.

	Etienne Segonzac (:etienne) Assignee
	Comment 5 • 10 years ago

Apparently the appWindow is resized correctly the the homescreen isn't, patch incoming.

	Kevin Grandon :kgrandon Reporter
	Comment 6 • 10 years ago

Thanks Etienne! It's all yours :)

	Etienne Segonzac (:etienne) Assignee
	Comment 7 • 10 years ago

What do you think?
Sounds fair to resize the homescreen on every system-resize when it's loaded.
And that will be one less reflow when coming back to the homescreen :)

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 8 • 10 years ago

Sorry I don't think so.. that means homescreen will resize when you have a foreground app using keyboard or when you have a landscape foreground app.

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 9 • 10 years ago

(In reply to Alive Kuo [:alive][NEEDINFO!][5/11-5/15@MV] from comment #8)
> Sorry I don't think so.. that means homescreen will resize when you have a
> foreground app using keyboard or when you have a landscape foreground app.

OK so this is regressed from bug 1011262. My idea is always resized at opened handler. Could we redo that?

	Etienne Segonzac (:etienne) Assignee
	Comment 10 • 10 years ago

(In reply to Alive Kuo [:alive][NEEDINFO!][5/11-5/15@MV] from comment #8)
> Sorry I don't think so.. that means homescreen will resize when you have a
> foreground app using keyboard or when you have a landscape foreground app.

Good point.

Resizing at opened won't help with this bug since the system-resize occurs with no app change, we stay on the settings app.

We can:
* make sure the software button always has a higher z-index than the homescreen
* keep the homescreenwindow specific resize method and ignore keyboard related system-resize when !isActive().

Any preference?

	Etienne Segonzac (:etienne) Assignee
	Comment 11 • 10 years ago

Comment on attachment 8424956 [details]
Gaia PR

clearing the r? flag until we decide on a solution

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 12 • 10 years ago

(In reply to Etienne Segonzac (:etienne) from comment #10)
> (In reply to Alive Kuo [:alive][NEEDINFO!][5/11-5/15@MV] from comment #8)
> > Sorry I don't think so.. that means homescreen will resize when you have a
> > foreground app using keyboard or when you have a landscape foreground app.
> 
> Good point.
> 
> Resizing at opened won't help with this bug since the system-resize occurs
> with no app change, we stay on the settings app.

Well, I am sure if we don't resize on opened we will regress bug 1003870.
What about do both - resize active app and resize in _opened? Does this regress 1011262?

> 
> We can:
> * make sure the software button always has a higher z-index than the
> homescreen
> * keep the homescreenwindow specific resize method and ignore keyboard
> related system-resize when !isActive().
> 
> Any preference?

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 13 • 10 years ago

I tried to add this.app.resize back and keep appWindowManager resize activeApp -- it seems homescreen correct resizes but settings app is resized with fade-overlay's size larger than its container appWindow which is correctly resized to 100%-2.4rem-5rem
Strange..

	Etienne Segonzac (:etienne) Assignee
	Comment 14 • 10 years ago

Comment on attachment 8424956 [details]
Gaia PR

And how about resizing the homescreen from the launcher just for software-button events?

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 15 • 10 years ago

Comment on attachment 8424956 [details]
Gaia PR

For now Let's do this. I am adjusting resize logic (again) in bug 992085.

	Etienne Segonzac (:etienne) Assignee
	Comment 16 • 10 years ago

https://github.com/mozilla-b2g/gaia/commit/5f29469b4a9a728781430a0c426f1978529d1de9

	Carsten Book [:Tomcat]
	Comment 17 • 10 years ago

sorry had to revert this change since i guess this caused https://tbpl.mozilla.org/php/getParsedLog.php?id=40534597&tree=B2g-Inbound

	Etienne Segonzac (:etienne) Assignee
	Comment 18 • 10 years ago

New gaia PR: https://github.com/mozilla-b2g/gaia/pull/19726

	Etienne Segonzac (:etienne) Assignee
	Comment 19 • 10 years ago

Try build: https://tbpl.mozilla.org/?tree=Try&rev=6569e4a5ca71

	Etienne Segonzac (:etienne) Assignee
	Comment 20 • 10 years ago

Relanded with travis and try green:
https://github.com/mozilla-b2g/gaia/commit/9833baf032ad5524b8e7f0e0adcceb450f7c8aac

	Kevin Grandon :kgrandon Reporter
	Comment 21 • 10 years ago

Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.