Closed
Bug 1012647
Opened 10 years ago
Closed 10 years ago
Create mozilla-esr31 branch
Categories
(Release Engineering :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: massimo)
References
Details
Attachments
(7 files, 1 obsolete file)
(deleted),
patch
|
nthomas
:
review+
massimo
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
nthomas
:
review+
massimo
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
rail
:
review+
massimo
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
rail
:
review+
massimo
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
rail
:
review+
massimo
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
rail
:
review+
massimo
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
nthomas
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #913195 +++
Like bug 913195 and bug 796995, but for esr31 this cycle.
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → mgervasini
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
tools changes for esr31
Attachment #8448431 -
Flags: review?(nthomas)
Assignee | ||
Comment 2•10 years ago
|
||
buildbot-configs changes for esr31
Attachment #8448432 -
Flags: review?(nthomas)
Comment 3•10 years ago
|
||
Comment on attachment 8448431 [details] [diff] [review]
tools-esr31.patch
>diff --git a/buildbot-helpers/mozconfig_whitelist b/buildbot-helpers/mozconfig_whitelist
I'm not sure if this will work or not, have you tested ? I'll r+ for the rest and ask you check it out. There's reasonable chance that copying the whitelist from esr24 will have missed changes on release in the meantime. We have this funny mismash of release sanity checks, and the in-tree mozconfigs and whitelist (see browser/config/mozconfigs/whitelist, which we verify each time 'make check' is run on a dep build).
>diff --git a/scripts/preproduction/repo_setup_config.py b/scripts/preproduction/repo_setup_config.py
Don't worry about this one, preproduction is deader than a dead thing.
Attachment #8448431 -
Flags: review?(nthomas) → review+
Comment 4•10 years ago
|
||
Comment on attachment 8448432 [details] [diff] [review]
buildbot-configs-esr31.patch
Nearly there, but needs a few minor fixes.
>diff --git a/mozilla-tests/config.py b/mozilla-tests/config.py
>+BRANCHES['mozilla-esr31']['xperf_tests'] = (0, False, TALOS_TP_NEW_OPTS, WIN7_ONLY)
Strongly suspect this was set for esr24 because xperf wasn't supported on 24. We do have it enabled on beta so lets remove this line.
>diff --git a/mozilla/config.py b/mozilla/config.py
>+ 'mozilla-esr31': {
>+ 'branch_projects': [],
>+ 'lock_platforms': True,
>+ 'gecko_version': 31,
>+ 'platforms': {
>+ 'linux': {},
>+ 'linux64': {},
...
We may need android-armv6 here too. Check with coop on the status of dropping Android 2.2 support.
>diff --git a/mozilla/master_common.py b/mozilla/master_common.py
> BRANCH_PRIORITIES = {
> 'mozilla-release': 0,
> 'comm-esr24': 0,
>+ 'comm-esr31': 0,
> 'mozilla-esr24': 1,
Please change this to mozilla-esr31.
>diff --git a/mozilla/preproduction_config.py b/mozilla/preproduction_config.py
>diff --git a/mozilla/preproduction_release_overrides-esr31.py b/mozilla/preproduction_release_overrides-esr31.py
Can leave both of these out, the parrot is dead. [http://www.youtube.com/watch?v=npjOSLCR2hE]
>diff --git a/mozilla/staging_release-firefox-mozilla-esr24.py b/mozilla/staging_release-firefox-mozilla-esr31.py
Needs the js/src/config/milestone.txt removal from bumpFiles; the template does too. Might find some other things if you diff against the template.
>diff --git a/mozilla/staging_release-firefox-mozilla-esr24.py b/mozilla/staging_release-firefox-mozilla-esr31.py.template
>similarity index 77%
>copy from mozilla/staging_release-firefox-mozilla-esr24.py
>copy to mozilla/staging_release-firefox-mozilla-esr31.py.template
Ooof, did this one the hard way ;-)
>diff --git a/setup-master.py b/setup-master.py
> [('staging_release-thunderbird-comm-%s.py' % v,
> 'release-thunderbird-comm-%s.py' % v)
>- for v in ['beta', 'release', 'esr24']
>+ for v in ['beta', 'release', 'esr24', 'esr31']
This will likely break test-masters.sh, as the release configs aren't being added by the patch. It's fine to leave comm-esr31 to other patches.
Attachment #8448432 -
Flags: review?(nthomas) → review-
Assignee | ||
Comment 5•10 years ago
|
||
Thanks for the review, nthomas. Here's an updated version of the patch
Attachment #8448432 -
Attachment is obsolete: true
Attachment #8449743 -
Flags: review?(nthomas)
Updated•10 years ago
|
Attachment #8449743 -
Flags: review?(nthomas) → review+
Assignee | ||
Updated•10 years ago
|
Attachment #8448431 -
Flags: checked-in+
Assignee | ||
Updated•10 years ago
|
Attachment #8449743 -
Flags: checked-in+
Assignee | ||
Comment 6•10 years ago
|
||
added mozilla/release-firefox-mozilla-esr31.py, added releaseConfig['skip_updates'] = True in mozilla/release-firefox-mozilla-esr31.py.template
Attachment #8450356 -
Flags: review?(rail)
Reporter | ||
Updated•10 years ago
|
Attachment #8450356 -
Flags: review?(rail) → review+
Assignee | ||
Updated•10 years ago
|
Attachment #8450356 -
Flags: checked-in+
Comment 7•10 years ago
|
||
Merged to production, and deployed.
Assignee | ||
Comment 8•10 years ago
|
||
Added mozilla2/linux/mozilla-esr31/release/mozconfig as a copy of esr24
Attachment #8452404 -
Flags: review?(rail)
Reporter | ||
Comment 9•10 years ago
|
||
Comment on attachment 8452404 [details] [diff] [review]
[buildbot-configs] Bug 1012647 - add mozconfig for esr31.patch
stamp
Attachment #8452404 -
Flags: review?(rail) → review+
Assignee | ||
Updated•10 years ago
|
Attachment #8452404 -
Flags: checked-in+
Assignee | ||
Comment 10•10 years ago
|
||
updated mozconfig_whitelist file needed by the esr31 staging release
Attachment #8453927 -
Flags: review?(rail)
Reporter | ||
Updated•10 years ago
|
Attachment #8453927 -
Flags: review?(rail) → review+
Assignee | ||
Comment 11•10 years ago
|
||
this patches removes the partialUpdates because the first esr31 has none. The skip_update is at the top with a hug HACK ALERT and must be removed after this release
Attachment #8453945 -
Flags: review?(rail)
Reporter | ||
Updated•10 years ago
|
Attachment #8453945 -
Flags: review?(rail) → review+
Assignee | ||
Updated•10 years ago
|
Attachment #8453945 -
Flags: checked-in+
Assignee | ||
Updated•10 years ago
|
Attachment #8453927 -
Flags: checked-in+
Comment 12•10 years ago
|
||
Merged to production, and deployed.
Comment 13•10 years ago
|
||
So is this branch already up-to-date or do we still have to push the latest state from the mozilla-release branch (from after todays merge) to it?
Reporter | ||
Comment 14•10 years ago
|
||
I pulled new changes from mozilla-release after the merge push and applied this patch on top of default to update the branding:
http://hg.mozilla.org/releases/mozilla-esr31/rev/450086c0ded0
Comment 15•10 years ago
|
||
Looks like we need the equivalent patch to
http://hg.mozilla.org/releases/mozilla-release/diff/d33428174ff1/browser/confvars.sh
Reporter | ||
Comment 16•10 years ago
|
||
Attachment #8455644 -
Flags: review?(nthomas)
Updated•10 years ago
|
Attachment #8455644 -
Flags: review?(nthomas) → review+
Reporter | ||
Comment 17•10 years ago
|
||
Comment on attachment 8455644 [details] [diff] [review]
update channel
https://hg.mozilla.org/releases/mozilla-esr31/rev/e91c79c4c04b
Attachment #8455644 -
Flags: checked-in+
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•