This can happen after bug 986599, but isn't as urgent.

[root@hp1 ~]# facter -p > after.txt [root@hp1 ~]# diff -u {before,after}.txt --- before.txt 2014-06-17 11:52:02.594599492 -0700 +++ after.txt 2014-06-17 11:52:23.006600145 -0700 @@ -30,7 +30,7 @@ env_term => screen env_tmout => 86400 env_user => root -facterversion => 1.7.5 +facterversion => 2.0.1 filesystems => ext3,ext4 fqdn => hp1.relabs.releng.scl3.mozilla.com hardwareisa => x86_64 @@ -59,10 +59,9 @@ macaddress_eth1 => b4:99:ba:a8:8a:69 manufacturer => HP memoryfree => 3.63 GB -memoryfree_mb => 3722.14 +memoryfree_mb => 3722.10 memorysize => 3.82 GB memorysize_mb => 3912.37 -memorytotal => 3.82 GB mtu_eth0 => 1500 mtu_eth1 => 1500 mtu_lo => 16436 @@ -110,6 +109,6 @@ uptime => 31 days uptime_days => 31 uptime_hours => 765 -uptime_seconds => 2756373 +uptime_seconds => 2756394 uuid => 36383236-3139-4D32-3231-323130333544 virtual => physical (confirmed that both contain our custom facts). Similarly, [root@relabs-puppet2.relabs.releng.scl3.mozilla.com dmitchell]# diff -u {before,after}.txt --- before.txt 2014-06-17 11:54:32.897890300 -0700 +++ after.txt 2014-06-17 11:54:58.910332408 -0700 @@ -43,7 +43,7 @@ env_tmout => 86400 env_user => root env_username => root -facterversion => 1.7.5 +facterversion => 2.0.1 filesystems => ext4,iso9660 fqdn => relabs-puppet2.relabs.releng.scl3.mozilla.com hardwareisa => x86_64 @@ -65,11 +65,10 @@ macaddress => 00:50:56:BB:56:52 macaddress_eth0 => 00:50:56:BB:56:52 manufacturer => VMware, Inc. -memoryfree => 2.09 GB -memoryfree_mb => 2144.47 +memoryfree => 2.10 GB +memoryfree_mb => 2145.43 memorysize => 2.82 GB memorysize_mb => 2887.37 -memorytotal => 2.82 GB mtu_eth0 => 1500 mtu_lo => 16436 needs_reboot_for_reboot_after_puppet => false @@ -111,7 +110,7 @@ uptime => 92 days uptime_days => 92 uptime_hours => 2209 -uptime_seconds => 7955495 +uptime_seconds => 7955521 uuid => 423B4E42-91B4-9A84-08A3-8BFEBF7842F4 virtual => vmware vmwaretools_version => 9.4.0-1280544

[root@t-mavericks-r5-002.test.releng.scl3.mozilla.com ~]# diff -u {before,after}.txt --- before.txt 2014-06-17 12:29:30.000000000 -0700 +++ after.txt 2014-06-17 12:30:27.000000000 -0700 @@ -20,7 +20,7 @@ env_tmpdir => /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/ env_user => root existing_slave_trustlevel => try -facterversion => 1.7.5 +facterversion => 2.0.1 fqdn => t-mavericks-r5-002.test.releng.scl3.mozilla.com hardwareisa => i386 hardwaremodel => x86_64 @@ -48,11 +48,10 @@ macosx_productversion => 10.9 macosx_productversion_major => 10.9 macosx_productversion_minor => 0 -memoryfree => 6.35 GB -memoryfree_mb => 6506.17 +memoryfree => 6.31 GB +memoryfree_mb => 6464.50 memorysize => 8.00 GB memorysize_mb => 8192.00 -memorytotal => 8.00 GB mtu_bridge0 => 1500 mtu_en0 => 1500 mtu_en1 => 1500 @@ -98,7 +97,7 @@ sp_secure_vm => secure_vm_enabled sp_serial_number => C07H606JDKDJ sp_smc_version_system => 1.77f0 -sp_uptime => up 0:4:2:21 +sp_uptime => up 0:4:3:18 sp_user_name => System Administrator (root) sshdsakey => AAAAB3NzaC1kc3MAAACBAIXOnly8U0RhWA5y2nwMsmfsa3i+NmGkC0Q2ynWD96o08Ro1xg90tuJUC8+OE86qxoF32TMP1LulvvtCFpbGALCIm5XZxK1UmtnjcZvPkEVzQOH/qQMLOPW2WyaeK8F4/KWBCz8osKH+vex3UIXthaZXHXB9VcWvmVzgFOo8XjApAAAAFQD/xr1sBBwQnNPvEFmvYLjHmJMRRQAAAIA6Mu68Q1OIERCCmWiGw1eSPW4N5MPJans5inRHgboK1t//6TW+X13ToDusjO9t01vs5PkjOD0cvxmuivHhxsaETBLirP9cJCpLqZlY908dvC1Qatsgr2s211AvTQBb8HQXOZs8/dIZGb9jPpx1ngBnGOGopABJbiD5dumGc5GfuwAAAIEAg0fDor2QWwcGhXLiDMFiklrypBsSxzCVs4pJSX3WUumHUPpYvVZRtgKfW4EKRSAItllbMys4ZDjD0ZFMPbk3zMYYMN0bDH5rF3PFgh14PknioZpSscrQjgUEHD+EjYyC9DBIrqs8ZLsE+0TvaoZLqfmkgH9ao3hqQKFlug7SHFQ= sshfp_dsa => SSHFP 2 1 d2d64e7f4ebe5062e744e45e958c508eabd44ee7 @@ -112,8 +111,8 @@ swapsize => 1024.00 MB swapsize_mb => 1024.00 timezone => PDT -uptime => 4:01 hours +uptime => 4:02 hours uptime_days => 0 uptime_hours => 4 -uptime_seconds => 14511 +uptime_seconds => 14569 virtual => physical

[root@hp1 ~]# facter operatingsystemrelease 12.04 works fine (as I read bug 1019794, this was *fixed* in 2.0.0, so would only be problematic if code expected the old, broken behavior)

> Facter bug #322 changes the behavior of exec() calls to return empty string "" rather > than nil. This breaks all instances of .nil? in our custom facts, affecting a wide > variety of things. This affects the iptables_persistent_version fact, which is part of the 'firewall' module, but not in a serious way. The upstream version of this module hasn't been updated to fix this. So, I think this is good to go with no issues expected. I need to mirror facter-2.0.2 everywhere, and at the moment puppetlabs' rsync server is busy.

That's bug https://tickets.puppetlabs.com/browse/PUP-2785

The puppet bug seems to be resolved (even if it's still open). I've sync'd the repos.

Simple patch, but r? pmoore so it can double as a heads-up to buildduty. I'll deploy this in my environment first and re-test it on a variety of systems (including all OS X versions), but based on the above I don't expect any issues at all.

Comment on attachment 8452277 [details] [diff] [review] bug1014047.patch lgtm. Thanks Dustin.

OK, tested on all versions of OS X that we run, along with Ubuntu and CentOS.