Closed
Bug 1015147
Opened 11 years ago
Closed 11 years ago
Put the user-agent style sheets svg.css and mathml.css in the style sheet cache
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: jwatt, Assigned: jwatt)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [MemShrink])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
The user-agent style sheets svg.css and mathml.css should be in the style sheet cache. I don't believe there's any reason to be creating a new instance of these style sheets for each document that needs them.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8427713 -
Flags: review?(bzbarsky)
|
|
||
Comment 3•11 years ago
|
||
Ah, so svg.css used to be loaded at startup anyway as part of ua.css, right?
|
|
Assignee | |
Comment 4•11 years ago
|
||
Back in 2005, yeah, but bug 287389 changed that.
So my reason for here loading it up front in the cache is that all our products load SVG during startup (like HTML and XUL), so we should cache the SVG sheet (like for HTML and XUL).
|
|
||
Comment 5•11 years ago
|
||
Oh, I see.
Yeah, ok. svg.css is pretty small anyway...
|
|
Assignee | |
Comment 6•11 years ago
|
||
Rotted myself with changes to the patch in bug 1014891 - updating for that.
Attachment #8427713 -
Attachment is obsolete: true
Attachment #8427713 -
Flags: review?(bzbarsky)
Attachment #8427943 -
Flags: review?(bzbarsky)
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 8427943 [details] [diff] [review]
patch
Why not just:
if (mOnDemandBuiltInUASheets.Contains(aSheet)) {
return;
}
instead of reinventing it?
And also, just early return if !aSheet instead of adding null to the list.
>- mOnDemandBuiltInUASheets.SizeOfExcludingThis(SizeOfStyleSheetsElementIncludingThis,
We should just pass null for the callback, no? We still want to measure the array memory.
r=me
Attachment #8427943 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Comment 9•11 years ago
|
||
|
||
Updated•11 years ago
|
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•