Closed
Bug 1015294
Opened 10 years ago
Closed 10 years ago
[Homescreen] Update to use gaia-header
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yor, Assigned: wilsonpage)
References
Details
Attachments
(5 files)
No description provided.
Blocks: gaia-header
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → wilsonpage
Assignee | ||
Comment 1•10 years ago
|
||
Initial patch. Need confirmation from visual on header color/theme.
Assignee | ||
Updated•10 years ago
|
Attachment #8469420 -
Flags: review?(kgrandon)
Comment 3•10 years ago
|
||
Comment on attachment 8471066 [details]
verticalhome-edit-header.png
Peter - could you give this a visual review? The color of the header is changing a bit here. Thanks!
Attachment #8471066 -
Flags: ui-review?(pla)
Hey Kevin, I'm going to needinfo Przemek here who is working on Frameworks. He'll provide the final color spec.
Flags: needinfo?(pabratowski)
Comment 5•10 years ago
|
||
The homescreen edit header color should be #333333. That is the same color as this screens overall background. This is intended to create a more seamless view. Spec attached. Note: since we are using one dark header for dark apps, the media, home edit and home collections screens will all use the #333333 header color. That means we'll have to adjust the background in the media apps if we want to create the same seamless feel throughout, I believe this is being done with Bug 1050404.
Flags: needinfo?(pabratowski)
Comment 6•10 years ago
|
||
Comment on attachment 8469420 [details] pull-request (master) Hey Wilson - need to make a few changes here before we can land this. we need to lazy load the header logic because it's not used onload, you can do so here: https://github.com/mozilla-b2g/gaia/blob/master/apps/verticalhome/js/app.js#L105 You should also remove the old logic if it's no longer needed. Is headers.css/font_size_utils.js still needed? Please make updates and flag me again, or if you're slammed you can assign to me and I'll take a look.
Attachment #8469420 -
Flags: review?(kgrandon) → review-
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8469420 [details]
pull-request (master)
UPDATED
- Lazy-load scripts added
- Updated gaia-theme to v0.2.1
- Curtain now uses dynamic theme --background color
- Updated fl app that also depends on gaia-theme (screen-shot attached)
Attachment #8469420 -
Flags: review- → review?(kgrandon)
Comment 10•10 years ago
|
||
Comment on attachment 8472293 [details]
verticalhome-updated-theme.png
This screen looks good, thanks.
Attachment #8472293 -
Flags: ui-review?(pabratowski) → ui-review+
Comment 11•10 years ago
|
||
Comment on attachment 8469420 [details]
pull-request (master)
Closer! But we now have a few failing marionette tests. Can you ensure the tests are working then flag me for review again? Thanks!
Attachment #8469420 -
Flags: review?(kgrandon) → review-
Assignee | ||
Comment 12•10 years ago
|
||
Comment on attachment 8469420 [details]
pull-request (master)
Looks like we're just getting a keyboard intermittent in gaia-try now. I've restarted a few times with no luck.
Attachment #8469420 -
Flags: review- → review?(kgrandon)
Comment 13•10 years ago
|
||
Comment on attachment 8469420 [details]
pull-request (master)
Seems fine, test is a bit sketchy cause we don't see it failing in master. Might want to either rebase or watch the tree after landing.
Attachment #8469420 -
Flags: review?(kgrandon) → review+
Attachment #8471066 -
Flags: ui-review?(pla)
Assignee | ||
Comment 14•10 years ago
|
||
Comment on attachment 8469420 [details] pull-request (master) LANDED https://github.com/mozilla-b2g/gaia/commit/e418b8cf30982a66bbcbb03846ecade68a8bc2d6
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•