Closed Bug 1015385 Opened 11 years ago Closed 10 years ago

[Camera] Implement new startup loading events

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S4 (20june)
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: Eli, Assigned: justindarc)

References

Details

(Keywords: perf, Whiteboard: [c=automation p= s=2014.06.20.t u=2.0])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #837668 +++ We need to measure when the app is usable by the user. For that we'll need to send an event (the moment is specific to the app) to |window| that the performance test will be able to receive. The events for implementation are outlined in bug 996038.
FYI, there is already a "startup-path-done" in that one.
Bug 996038 introduces new events outlining the phases of application startup. Each of these 5 events needs to be implemented. "startup-path-done" will be changed to the relevant event outlined in 996038.
Summary: [Camera] "ready to use" perf measurement → [Camera] Implement new startup loading events
Adding to 2.0 sprint4 for discussion during planning
Target Milestone: --- → 2.0 S4 (20june)
Assignee: nobody → jdarcangelo
Taking this bug now that I have a good grasp on understanding the new startup perf events from the FM Radio app.
Attached file pull-request (master) (deleted) —
Eli: I flagged you for review on this as well so you can take a quick look to make sure these events look like they're being used properly. The Camera app is a much better example of using these events more effectively since we asynchronously load a fair amount of the application after the critical path is done. Diego: Also take a look to sanity check from the Camera app perspective.
Attachment #8438597 - Flags: review?(eperelman)
Attachment #8438597 - Flags: review?(dmarcos)
Comment on attachment 8438597 [details] pull-request (master) Looks good on the performance side.
Attachment #8438597 - Flags: review?(eperelman) → review+
Comment on attachment 8438597 [details] pull-request (master) It looks good Justin
Attachment #8438597 - Flags: review?(dmarcos) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [c=automation p= s= u=] → [c=automation p= s=2014.06.20.t u=2.0]
Justin, just noticed that this one is missing an entry in the whitelist and didn't catch it with my review. Could you submit another patch for the additional whitelist entry? That patch and your existing one will needs to land in 2.0 as it is important for meeting release performance acceptance criteria [1]. https://wiki.mozilla.org/FirefoxOS/Performance/Release_Acceptance
Status: RESOLVED → REOPENED
Flags: needinfo?(jdarcangelo)
Resolution: FIXED → ---
Follow-up bug to update `whitelistedUnifiedApps` list: Bug 1024753 - [Camera] Add Camera app to whitelistedUnifiedApps Hema: Both this bug (Bug 1015385) and the follow-up (Bug 1024753) require v2.0 uplift approval according to Comment 9. Thanks!
Flags: needinfo?(jdarcangelo) → needinfo?(hkoka)
Closing this since we have a follow-up bug to update the whitelist: Bug 1024753 - [Camera] Add Camera app to whitelistedUnifiedApps
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Comment on attachment 8438597 [details] pull-request (master) See comment 9 for 2.0 approval justification: To measure and meet Release Performance Acceptance Criteria
Attachment #8438597 - Flags: approval-gaia-v2.0+
Flags: needinfo?(hkoka)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: