Closed Bug 1024753 Opened 10 years ago Closed 10 years ago

[Camera] Add Camera app to whitelistedUnifiedApps

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Camera
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(b2g-v2.0 fixed, b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S4 (20june)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

(Keywords: perf, Whiteboard: [c=automation p= s= u=])

Attachments

(1 file)

pull-request (master)
(deleted), text/x-github-pull-request
Eli
: review+
bajaj
: approval-gaia-v2.0+
Details
The new startup performance events were added to Camera in Bug 1015385. However, an entry needs to be added for the Camera app to the `whitelistedUnifiedApps` array in `tests/performance/startup_events_test.js`.
Attached file pull-request (master) (deleted) —
Eli: Flagging you for an easy review since this is your territory :-)
Attachment #8439548 - Flags: review?(eperelman)
Attachment #8439548 - Flags: review?(eperelman) → review+
Landed on master: https://github.com/mozilla-b2g/gaia/commit/ea748a0b69f22fdce7317d45ce2a7d03f5d3999e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee: nobody → jdarcangelo
Comment on attachment 8439548 [details] pull-request (master) Requesting uplift to 2.0 as it is important for meeting our release performance acceptance criteria. The associated patch for this implementation has already landed with the Camera app, so Camera is outputting the data but we cannot capture it without this entry. [Feature/regressing bug #]: bug 996038 [User impact if declined]: none [Describe test coverage new/current, TBPL]: Feature only triggers events for testing, no user-facing features or tests [Risks and why]: Low, as there are no user-perceived changes [String/UUID change made/needed]: n/a
Attachment #8439548 - Flags: approval-gaia-v2.0?
Blocks: 1038759
Bhavana + Preeti, Can we get approval on this? It's blocking our ability to do fxOS 2.0 Performance Signoff.
Severity: normal → blocker
Flags: needinfo?(praghunath)
Flags: needinfo?(bbajaj)
Keywords: perf
Priority: -- → P1
Whiteboard: [c=automation p= s= u=]
Attachment #8439548 - Flags: approval-gaia-v2.0? → approval-gaia-v2.0+
Flags: needinfo?(bbajaj)
Clearing ni? based on previous approval.
Flags: needinfo?(praghunath)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: