Closed
Bug 1015447
Opened 10 years ago
Closed 10 years ago
Add a new tab from horizontal tab strip
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: ywang, Assigned: lucasr)
References
Details
Attachments
(2 files)
(deleted),
image/jpeg
|
Details | |
(deleted),
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
With a horizontal tab strip[bug1014987], adding a new tab is just one tap away.
The “Plus” icon is always visible on the top right side of tab strip. If the user is in a private browsing mode, the "Plus" icon creates a private new tab.
Next step:
* Implementation
* Animation refinement
Reporter | ||
Updated•10 years ago
|
Blocks: new-tablet-v1
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8487177 [details] [diff] [review]
Top-level container for tab strip with 'new tab' button (r=mcomella)
Use a similar approach than BrowserToolbar: top-level container track tab events and forwards them as appropriate.
Attachment #8487177 -
Flags: review?(michael.l.comella)
Updated•10 years ago
|
Assignee: nobody → lucasr.at.mozilla
Status: NEW → ASSIGNED
Comment 3•10 years ago
|
||
Comment on attachment 8487177 [details] [diff] [review]
Top-level container for tab strip with 'new tab' button (r=mcomella)
Review of attachment 8487177 [details] [diff] [review]:
-----------------------------------------------------------------
::: mobile/android/base/tabs/TabStrip.java
@@ +70,5 @@
> + tabStripView.clearTabs();
> + }
> +
> + @Override
> + public void setPrivateMode(boolean isPrivate) {
This appears to be unused - fix it (and reflag for r?) or file a followup.
Attachment #8487177 -
Flags: review?(michael.l.comella) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8487177 [details] [diff] [review]
Top-level container for tab strip with 'new tab' button (r=mcomella)
(In reply to Michael Comella (:mcomella) from comment #3)
> Comment on attachment 8487177 [details] [diff] [review]
> Top-level container for tab strip with 'new tab' button (r=mcomella)
>
> Review of attachment 8487177 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: mobile/android/base/tabs/TabStrip.java
> @@ +70,5 @@
> > + tabStripView.clearTabs();
> > + }
> > +
> > + @Override
> > + public void setPrivateMode(boolean isPrivate) {
>
> This appears to be unused - fix it (and reflag for r?) or file a followup.
It's used when handling the SELECTED event.
Attachment #8487177 -
Flags: review+ → review?(michael.l.comella)
Comment 5•10 years ago
|
||
Comment on attachment 8487177 [details] [diff] [review]
Top-level container for tab strip with 'new tab' button (r=mcomella)
Review of attachment 8487177 [details] [diff] [review]:
-----------------------------------------------------------------
My mistake.
Attachment #8487177 -
Flags: review?(michael.l.comella) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•