Closed Bug 1067556 Opened 10 years ago Closed 10 years ago

Adjust new tab button's position and leftmost tab in tab strip

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 36

People

(Reporter: mcomella, Assigned: lucasr)

References

Details

Attachments

(2 files, 1 obsolete file)

prev_addtab_vishit_mock1.png
(deleted), image/png
Details
Adjust new tab button's position (r=mcomella)
(deleted), patch
mcomella
: review+
Details | Diff | Splinter Review
According to mocks, such as [1], the position of the new tab button should be directly above the options menu. [1]: https://bug1058909.bugzilla.mozilla.org/attachment.cgi?id=8480237
Also, the leftmost tab should have a larger margin.
Summary: Adjust new tab button's position in tab strip → Adjust new tab button's position and leftmost tab in tab strip
antlam, how the pressed state of the new tab button support to look? If we want to align it with the menu button below it, we'll have to add margin on the right of the button which makes the pressed state look a little weird because of the gap.
Flags: needinfo?(alam)
The + icon also needs to be updated I think. I'll get you a screenshot of the pressed state.
Flags: needinfo?(alam)
Attached image prev_addtab_vishit_mock1.png (deleted) —
This is what we're talking about right? The color is #45494E, derived form the background grey, same as the color of tapping a background tab, and the size of the visual feedback area is 34dp sq inside the hit area which is 48 dp sq.
Attached patch Adjust new tab button's position (r=mcomella) (obsolete) (deleted) — — Splinter Review
Attachment #8516687 - Flags: review?(michael.l.comella)
Attachment #8516687 - Attachment is obsolete: true
Attachment #8516687 - Flags: review?(michael.l.comella)
Comment on attachment 8516726 [details] [diff] [review] Adjust new tab button's position (r=mcomella) antlam-approved changes.
Attachment #8516726 - Flags: review?(michael.l.comella)
Filed bug 1093648 to follow-up on the "new tab" icon update across all our UIs.
Assignee: nobody → lucasr.at.mozilla
Status: NEW → ASSIGNED
Comment on attachment 8516726 [details] [diff] [review] Adjust new tab button's position (r=mcomella) Review of attachment 8516726 [details] [diff] [review]: ----------------------------------------------------------------- We might have some conflicts with the changes from bug 1085771, but we'll deal with those at that time.
Attachment #8516726 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/mozilla-central/rev/5ee9bf9dc083
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: