Closed
Bug 1015796
Opened 10 years ago
Closed 9 years ago
Followup of bug 1015090: Revise BluetoothAttributeEvent.webidl with attribute |attrs| as type sequence<DOMString>
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
2.2 S11 (1may)
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: ben.tian, Assigned: yrliou)
References
Details
(Whiteboard: [webbt-api])
Attachments
(1 file, 1 obsolete file)
Attribute |value| in BluetoothAttributeEvent.webidl should be revised to union type once IDL supports sequence in union type (bug 767921).
|
Reporter | |
Comment 1•10 years ago
|
||
Correct bug number to depend: 767924 Attribute |value| in BluetoothAttributeEvent.webidl should be revised to union type once IDL supports sequence in union type (bug 767924).
Depends on: 767924
Whiteboard: [webbt-api]
|
|
Reporter | |
Comment 2•10 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=415e0c583b4d
|
|
Reporter | |
Comment 3•10 years ago
|
||
Change bug title as we revise API design in bug 1019544 comment 30. We have to make attribute |attrs| of type sequence<DOMString> once sequence is supported in event codegen (bug 1023762).
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → joliu
|
|
Assignee | |
Comment 4•9 years ago
|
||
Hi Ben, Could you help to review my patch? Thanks, Jocelyn
Attachment #8593736 -
Flags: review?(btian)
|
|
Reporter | |
Comment 5•9 years ago
|
||
Comment on attachment 8593736 [details] [diff] [review] Bug 1015796: Use sequence<DOMString> as the type of attribute |attrs| in BluetoothAttributeEvent instead of any. Review of attachment 8593736 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Please request a DOM peer review for webidl change.
Attachment #8593736 -
Flags: review?(btian) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Comment on attachment 8593736 [details] [diff] [review] Bug 1015796: Use sequence<DOMString> as the type of attribute |attrs| in BluetoothAttributeEvent instead of any. Hi Blake, Could you help to review this webidl and related implementation change? Thanks, Jocelyn
Attachment #8593736 -
Flags: review?(mrbkap)
|
||
Updated•9 years ago
|
Attachment #8593736 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 7•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b063fab8d30
|
|
Assignee | |
Comment 8•9 years ago
|
||
Thanks for your time, Ben and Blake.
Attachment #8593736 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/d04f55be10fb
Keywords: checkin-needed
|
|
||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d04f55be10fb
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in
before you can comment on or make changes to this bug.
Description
•