Closed Bug 1017890 Opened 11 years ago Closed 11 years ago

HDPI support for responsive mode

Categories

(DevTools :: Responsive Design Mode, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 32

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Component: Developer Tools → Developer Tools: Responsive Mode
Attached patch Patch v1 (obsolete) (deleted) — Splinter Review
Put the responsive mode images into the browser[...]/devtools/images/responsivemode folder (I like things organized). Also added HDPI support of course.
Assignee: nobody → ntim007
Status: NEW → ASSIGNED
Attachment #8432147 - Flags: review?(bgrinstead)
Comment on attachment 8432147 [details] [diff] [review] Patch v1 Looks like I forgot to hg add the new files.
Attachment #8432147 - Flags: review?(bgrinstead)
Attached patch Patch v2 (deleted) — Splinter Review
Fixed missing files
Attachment #8432147 - Attachment is obsolete: true
Attachment #8432184 - Flags: review?(bgrinstead)
Attachment #8432184 - Attachment description: responsive-mode-hdpi.patch → Patch v2
(In reply to Tim Nguyen [:ntim] from comment #5) > Pushed to try : https://tbpl.mozilla.org/?tree=Try&rev=531f067b9ecf FYI, you shouldn't need to include android in the list of platforms for devtools frontend changes. This commit message should be enough: try: -b do -p linux,linux64,macosx64,win32 -u xpcshell,mochitest-dt,mochitest-o,mochitest-bc -t none
Comment on attachment 8432184 [details] [diff] [review] Patch v2 Review of attachment 8432184 [details] [diff] [review]: ----------------------------------------------------------------- This looks great in 2x. Don't see anything that needs to change
Attachment #8432184 - Flags: review?(bgrinstead) → review+
(In reply to Brian Grinstead [:bgrins] from comment #6) > (In reply to Tim Nguyen [:ntim] from comment #5) > > Pushed to try : https://tbpl.mozilla.org/?tree=Try&rev=531f067b9ecf > > FYI, you shouldn't need to include android in the list of platforms for > devtools frontend changes. This commit message should be enough: try: -b do > -p linux,linux64,macosx64,win32 -u > xpcshell,mochitest-dt,mochitest-o,mochitest-bc -t none OK, I'll keep that in mind :)
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: