Closed
Bug 837188
Opened 12 years ago
Closed 11 years ago
Use 2x images for Developer Tools UI for HiDPI
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox32 fixed, relnote-firefox 32+)
RESOLVED
FIXED
Firefox 32
People
(Reporter: shorlander, Assigned: bgrins)
References
(Blocks 2 open bugs)
Details
(Keywords: feature)
Attachments
(1 file)
(deleted),
application/zip
|
Details |
The DevTools UI needs images and CSS rules for HiDPI screens.
Comment 1•12 years ago
|
||
(In reply to Stephen Horlander from comment #0)
> The DevTools UI needs images and CSS rules for HiDPI screens.
I don't anything about HiDPI. How does it work? Do we have special mediaqueries/classes to know when to use the right images?
Comment 2•12 years ago
|
||
(In reply to Paul Rouget [:paul] from comment #1)
> I don't anything about HiDPI. How does it work? Do we have special
> mediaqueries/classes to know when to use the right images?
@media (min-resolution: 2dppx) {
.something {
background-image: url("image@2x.png");
background-size: |double|px;
}
}
Reporter | ||
Comment 3•12 years ago
|
||
Also see bug 781327 for how it was done for the main browser UI.
Updated•12 years ago
|
Blocks: DevToolsPaperCuts
Updated•12 years ago
|
Blocks: osx-hidpi
Summary: Use 2x Image for Developer Tools UI for HiDPI → Use 2x images for Developer Tools UI for HiDPI
Updated•12 years ago
|
Assignee: nobody → paul
Comment 4•11 years ago
|
||
Stephen, can you provide the icons for this? At least the tools' icons (in the tabs).
Flags: needinfo?(shorlander)
Reporter | ||
Comment 5•11 years ago
|
||
These are all the icons from the osx and shared themes directories except the breadcrumbs.
I took the opportunity to clean up all the @1x icons as well so if you could please just do an image swap on those when adding the @2x versions.
Will follow-up with the breadcrumbs images.
Flags: needinfo?(shorlander)
Comment 6•11 years ago
|
||
For the breadcrumbs, can you just provide the arrow we see here: http://people.mozilla.org/~shorlander/mockups/devTools/ux-refresh-2013/DarkTheme-Inspector-Active@2x.png ?
Assignee | ||
Comment 8•11 years ago
|
||
Bug 947309 uses 2x icons for the top toolbar. The remaining icons that need to be converted to 2x (and moved into the shared folder) are: responsive mode, webconsole output, webconsole input prompt, inspector twisties and checkboxes, debugger breakpoint, debugger widget arrow, debugger icons (controls and blackboxing & breakpoints buttons), style editor sidebar arrow & eye, profiler icon.
I will take a look at these and see how many changes will be needed for each, and if they can be done all together here.
Comment 9•11 years ago
|
||
Can I fix the remaining images ? If so, should I file a new bug (since this might be for tracking) ?
Flags: needinfo?(bgrinstead)
Comment 10•11 years ago
|
||
Ok, so I'm gonna split this up in multiple small bugs, otherwise it's gonna be a mess.
Flags: needinfo?(bgrinstead)
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Tim Nguyen [:ntim] from comment #9)
> Can I fix the remaining images ? If so, should I file a new bug (since this
> might be for tracking) ?
Please do!
(In reply to Tim Nguyen [:ntim] from comment #10)
> Ok, so I'm gonna split this up in multiple small bugs, otherwise it's gonna
> be a mess.
Yes, let's file a separate bug (blocking this one) for each image / each logical group of images.
Comment 13•11 years ago
|
||
Finally finished ! \o/
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox32:
--- → fixed
relnote-firefox:
--- → ?
Keywords: feature
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Assignee | ||
Comment 14•11 years ago
|
||
(In reply to Tim Nguyen [:ntim] from comment #13)
> Finally finished ! \o/
Yay! Thanks for all the patches ntim, looking sharp at 2x.
Updated•11 years ago
|
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•