Closed
Bug 1018446
Opened 11 years ago
Closed 11 years ago
Return errors properly in WebCryptoTasks
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: rbarnes, Assigned: rbarnes)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Currently, some WebCryptoTasks do not properly handle errors when encountered. Constructors should set mEarlyRv and return; other methods should just return the nsresult.
|
Assignee | |
Comment 1•11 years ago
|
||
Verified that all instances of "mEarlyRv = " are followed by returns, and all bare returns preceded by appropriate setting of mEarlyRv.
Attachment #8431917 -
Flags: review?(bzbarsky)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8431917 [details] [diff] [review]
webcrypto-1018446.patch
Typical DOM style is to not have else-after-return as you have in that second hunk.
r=me with that fixed.
Attachment #8431917 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Addressing bz's comment
Attachment #8431917 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•11 years ago
|
||
Missed a failure on one path (the test suite caught it, though).
Attachment #8434439 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•11 years ago
|
||
Try run covering:
* Bug 1018446
* Bug 1018467
* Bug 1020598
https://tbpl.mozilla.org/?tree=Try&rev=9f007e5cbf5e
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 7•11 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•