Closed Bug 1018467 Opened 11 years ago Closed 10 years ago

Address remaining comments from Bug 998802 and Bug 998803

Categories

(Core :: DOM: Security, defect)

Product:
Core
Component:
DOM: Security
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla32

People

(Reporter: rbarnes, Assigned: rbarnes)

Details

Attachments

(1 file, 1 obsolete file)

webcrypto-1018467.1.patch r=bz
(deleted), patch
Details | Diff | Splinter Review
The committed patches for Bug 998802 and Bug 998803 missed a few comments, in particular: https://bugzilla.mozilla.org/show_bug.cgi?id=998802#c12 https://bugzilla.mozilla.org/show_bug.cgi?id=998803#c10 This bug is to address those comments.
Attached patch webcrypto-1018467.patch (obsolete) (deleted) — — Splinter Review
Attachment #8431935 - Flags: review?(bzbarsky)
Comment on attachment 8431935 [details] [diff] [review] webcrypto-1018467.patch >+ equal = equal && (cmp == 0); Just equal = (cmp == 0), since you already know equal is true before that line. r=me
Attachment #8431935 - Flags: review?(bzbarsky) → review+
Attached patch webcrypto-1018467.1.patch r=bz (deleted) — — Splinter Review
Addressing bz's comments
Attachment #8431935 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/81f9c2027bc8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: