Closed
Bug 1018467
Opened 11 years ago
Closed 11 years ago
Address remaining comments from Bug 998802 and Bug 998803
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: rbarnes, Assigned: rbarnes)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
The committed patches for Bug 998802 and Bug 998803 missed a few comments, in particular:
https://bugzilla.mozilla.org/show_bug.cgi?id=998802#c12
https://bugzilla.mozilla.org/show_bug.cgi?id=998803#c10
This bug is to address those comments.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8431935 -
Flags: review?(bzbarsky)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8431935 [details] [diff] [review]
webcrypto-1018467.patch
>+ equal = equal && (cmp == 0);
Just equal = (cmp == 0), since you already know equal is true before that line.
r=me
Attachment #8431935 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Addressing bz's comments
Attachment #8431935 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•11 years ago
|
||
Try run covering:
* Bug 1018446
* Bug 1018467
* Bug 1020598
https://tbpl.mozilla.org/?tree=Try&rev=9f007e5cbf5e
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•