Closed
Bug 1019124
Opened 11 years ago
Closed 11 years ago
HDPI support for Canvas Debugger
Categories
(DevTools Graveyard :: Canvas Debugger, defect)
DevTools Graveyard
Canvas Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(2 files, 2 obsolete files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
ntim
:
review+
|
Details | Diff | Splinter Review |
canvas-2x.png
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8432666 -
Flags: review?(vporof)
Attachment #8432666 -
Flags: review?(bgrinstead)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8432666 [details] [diff] [review]
Patch
Review of attachment 8432666 [details] [diff] [review]:
-----------------------------------------------------------------
This doubles the size of the buttons (see screenshot). To test this, you can open canvas tool on a URL like http://madebyevan.com/webgl-water/ and press the capture button.
Attachment #8432666 -
Flags: review?(vporof)
Attachment #8432666 -
Flags: review?(bgrinstead)
Attachment #8432666 -
Flags: review-
|
|
||
Comment 3•11 years ago
|
||
Screenshot of canvas inspector at 2x with patch applied
|
|
||
Comment 4•11 years ago
|
||
I think this is the same thing we ran into with the net monitor in Bug 1012139
|
|
Assignee | |
Comment 5•11 years ago
|
||
Fixed issue.
Attachment #8432666 -
Attachment is obsolete: true
Attachment #8432668 -
Flags: review?(vporof)
Attachment #8432668 -
Flags: review?(bgrinstead)
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8432668 [details] [diff] [review]
Patch v1.1
Review of attachment 8432668 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM - let Victor take a look before proceeding
Attachment #8432668 -
Flags: review?(bgrinstead) → review+
|
||
Updated•11 years ago
|
Attachment #8432668 -
Flags: review?(vporof) → review+
|
|
||
Comment 7•11 years ago
|
||
Please update the commit message to include reviewer(s) and push to try before marking checkin-needed
|
|
Assignee | |
Comment 8•11 years ago
|
||
Attachment #8432668 -
Attachment is obsolete: true
Attachment #8432679 -
Flags: review+
|
|
Assignee | |
Comment 9•11 years ago
|
||
Pushed to try : https://tbpl.mozilla.org/?tree=Try&rev=78954de8a8c6
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 10•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 11•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•