Run BinScope on all DLLs and EXEs that we build
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox-esr68 wontfix, firefox74 wontfix, firefox75 wontfix, firefox76 fixed)
People
(Reporter: TimAbraldes, Assigned: glandium)
References
Details
(Keywords: sec-want, Whiteboard: [sg:want P2][post-critsmash-triage][adv-main76-][adv-ESR68.8-])
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
Reporter | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Reporter | ||
Comment 3•10 years ago
|
||
Reporter | ||
Comment 4•10 years ago
|
||
Comment 5•9 years ago
|
||
Comment 6•9 years ago
|
||
Reporter | ||
Comment 7•9 years ago
|
||
Updated•7 years ago
|
Updated•7 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 9•5 years ago
|
||
This needs a few adjustments to the autobinscope script because running
binscope currently creates an HTML file in the binscope directory, and
when multiple binscopes run at the same time (which happens during the
build with the changes to run it on all executables and libraries), all
but one fail to open the HTML file for write access.
So add a flag to create that file in a temporary directory.
While here, remove log_file_path, which hasn't been used since
bug 1448306.
Assignee | ||
Comment 10•5 years ago
|
||
For the record, this was landed and subsequently backed out. It turns out this fails on 32-bits PGO builds, both generate and use.
z:\task_1584670060\workspace\obj-build\toolkit\crashreporter\injector\breakpadinjector.dll: error BA2013: breakpadinjector.dll is a C or C++ binary that does not initialize the stack protector. The stack protector (/GS) is a security feature of the compiler which makes it more difficult to exploit stack buffer overflow memory corruption vulnerabilities. The stack protector requires access to entropy in order to be effective, which means a binary must initialize a random number generator at startup, by calling __security_init_cookie() as close to the binary's entry point as possible. Failing to do so will result in spurious buffer overflow detections on the part of the stack protector. To resolve this issue, use the default entry point provided by the C runtime, which will make this call for you, or call __security_init_cookie() manually in your custom entry point.
But now that bug 1620166 landed, this could reland without breaking anything because the PGO builds don't run autobinscope anymore, but I'd rather wait for subsequent changes (such as bug 1450088 and bug 1618782) to be ready before doing so (in case 1620166 is backed out again)
Comment 11•5 years ago
|
||
https://hg.mozilla.org/integration/autoland/rev/36adb430f4fb0ed289813edd1ee70b1424543d83
https://hg.mozilla.org/mozilla-central/rev/36adb430f4fb
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•4 years ago
|
Description
•