Closed Bug 1021479 Opened 10 years ago Closed 10 years ago

[VsD Refresh] Lockscreen Visual Refresh: Slider arrow size

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Lockscreen
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S3 (6june)

People

(Reporter: mnjul, Assigned: mnjul)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, bokken [p=1])

User Story

+++ This bug was initially created as a clone of Bug #1020115 +++

+++ This bug was initially created as a clone of Bug #950884 +++

According to bug 950884 comment 50 we still have follow up to do. 

Howie, how do we track this? What's the schedule requirement of this follow up?

John, do you have time to address this?

Attachments

(1 file)

Patch
(deleted), text/x-github-pull-request
gweng
: review+
Details 
+++ This bug was initially created as a clone of Bug #1020115 +++

+++ This bug was initially created as a clone of Bug #950884 +++

This bug seeks to address the third issue of https://bugzilla.mozilla.org/show_bug.cgi?id=950884#c50 : Lockscreen slider's arrows look fuzzy on Flame.
Attached file Patch (deleted) — 
Here is the patch for correct arrow size. Greg, could you do a quick review for me? Thanks.
Attachment #8435494 - Flags: review?(gweng)
Comment on attachment 8435494 [details]
Patch

Looks great and it's a simple patch. Thanks for investigation!
Attachment #8435494 - Flags: review?(gweng) → review+
No longer blocks: 950884
No longer depends on: 1020115
Master: https://github.com/mozilla-b2g/gaia/commit/3133d37546e27f557e578a6ba1820dc954a5e383
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: ux-tracking, visual design, visual-tracking, bokken → ux-tracking, visual design, visual-tracking, bokken [p=1]
Target Milestone: 2.0 S4 (20june) → 2.0 S3 (6june)
No longer blocks: 1024845
blocking-b2g: --- → 2.0?
John Lu, can you please seek approval here to get this uplifted?
blocking-b2g: 2.0? → ---
Flags: needinfo?(jlu)
blocking-b2g: --- → 2.0?
blocking-b2g: 2.0? → ---
Hi Bhavana, 

The patch for this issue landed onto master before merge-day cutoff, and is currently present in v2.0 branch. In this case, do I still need to request for approval? Thanks.
Flags: needinfo?(jlu)
(In reply to John Lu [:mnjul] @MoCoTaipei from comment #5)
> Hi Bhavana, 
> 
> The patch for this issue landed onto master before merge-day cutoff, and is
> currently present in v2.0 branch. In this case, do I still need to request
> for approval? Thanks.

whoops, totally my bad, I got confused here as this nominated for blocking. Since its already in the 2.0 branch we are good here. Apologies!
No worries ;)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: