John Lu [:mnjul][Please NI or I'll miss] Assignee
	Description • 10 years ago

> Hey John 
> 
> We're looking to do a straight asset swap of a couple of icons (arrow and lock). If you could help with this, that would be fantastic. 
> 
> Please let me know if you have any questions. 
> 
> Thanks
> Hung

Hi Fang, could you generate the necessary PNG files from the original bug's SVG? Please see bug 1020115 c12 thanks.

	Hung Nguyen
	Comment 1 • 10 years ago

Hey John 

Attached you'll find the PNG assets. Let me know if you need anything else. 

Thanks for taking care of this. 

Cheers
Hung

	John Lu [:mnjul][Please NI or I'll miss] Assignee
	Comment 2 • 10 years ago

Hi Hung,

Thanks for the files. I've got two questions/requests:

1. Please make me the mirrored arrow too (ie. we have left arrows now, and I need right arrows too, thanks)

2. The new lock icon PNGs are quite larger dimensionally than the old (already-in-repository) ones, but  they look of similar sizes in contextual screenshots. For example, the new 1x PNG is about 42px in height, but the old 1x PNG is about 30px in height. Please resize the image dimensions for me, Thanks.

(...and yes, engineers don't have Photoshop and/or Illustrator. Haha.)

	Hung Nguyen
	Comment 3 • 10 years ago

No worries - That's what us designer are for. :) 

Here are the updated assets. Flag me for a UI review once the graphics are implemented. 

Thanks John and let me know if you need anything else.

	John Lu [:mnjul][Please NI or I'll miss] Assignee
	Comment 4 • 10 years ago

Hi Hung,

The new files are good! Please take a moment to review the screenshot with the new assets applied. Please note that the unlock icon was upped by 3px some while ago with bug 1021391, and if you want its vertical position adjusted again, please tell me. Thanks!

	Hung Nguyen
	Comment 6 • 10 years ago

Comment on attachment 8441837 [details]
2014-06-18-11-52-11.png

Thanks for this John. 

Overall it looks pretty good. I just need you to make one minor adjustment to the vertical position of the lock icon. Could you lower it by 2 px vertically? 

We should be good to go after that. :)

	Hung Nguyen
	Comment 7 • 10 years ago

Sorry John but I made a mistake with the previous assets that I provided you (they're a little too big). 

If you could please swap in the new ones attached, that would be awesome. 

Thanks!

	bhavana bajaj [:bajaj]
	Comment 8 • 10 years ago

Lets seek approval here when fixed, would not block the release on this

	Stephany Wilkes
	Comment 9 • 10 years ago

Hung, would this block the visual refresh? If the assets will be fuzzy or not work with the new homescreen in any way, the answer is yes. 

Who can set the approval flag on the new assets?

	Hung Nguyen
	Comment 10 • 10 years ago

Under that criteria, this should not block the visual refresh.

	Stephany Wilkes
	Comment 11 • 10 years ago

John, is the patch ready for approval?. If so, please add (or +) so this bug can move. Thanks!

	John Lu [:mnjul][Please NI or I'll miss] Assignee
	Comment 12 • 10 years ago

As we've swapped the assets & I was required, I'd like to request ui-review again. Code review will be requested when CI tests are passed...hopefully we can land it very soon

	Hung Nguyen
	Comment 13 • 10 years ago

Comment on attachment 8443345 [details]
2014-06-20-16-38-36.png

And that's a wrap. Looks great, thanks for all your help John. 

Cheers

	John Lu [:mnjul][Please NI or I'll miss] Assignee
	Comment 14 • 10 years ago

Comment on attachment 8441838 [details]
Patch (PR @ Github)

Hi Greg or Tim,

Could any of you review this trivial patch for me (only PNG files swap and one line of CSS change)? Or if none of you are available, could you tell me whom I may ask for review? Thanks.

	Greg Weng [:snowmantw][:gweng][:λ]
	Comment 15 • 10 years ago

Comment on attachment 8441838 [details]
Patch (PR @ Github)

Well, looks fine, although I think this would be more meaningful if it pass ui-review+.

	John Lu [:mnjul][Please NI or I'll miss] Assignee
	Comment 16 • 10 years ago

Master: https://github.com/mozilla-b2g/gaia/commit/591991e1eb3d1652f31c1b736dc832ebd0efb9f6

	John Lu [:mnjul][Please NI or I'll miss] Assignee
	Comment 17 • 10 years ago

Comment on attachment 8441838 [details]
Patch (PR @ Github)

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]

[Bug caused by] (feature/regressing bug #): UX requesting new assets to land into lockscreen

[User impact] if declined: very minimal -- they will see the old assets; everything still works

[Testing completed]: Yes, both TBPL and Travis

[Risk to taking this patch] (and alternatives if risky): minimal, as this is just PNG files and one line of CSS change

[String changes made]: None

	Ryan VanderMeulen [:RyanVM]
	Comment 18 • 10 years ago

v2.0: https://github.com/mozilla-b2g/gaia/commit/94eb8d53c0f33d18fae7273e18e21a3cddc2effc