Jan de Mooij [:jandem] Assignee
	Description • 10 years ago

      No description provided.

	Jan de Mooij [:jandem] Assignee
	Comment 1 • 10 years ago

Pass HandleLinearString instead of chars + length, to work better with Latin1 strings and moving GC.

	Jan de Mooij [:jandem] Assignee
	Comment 3 • 10 years ago

Allow storing both Latin1 and TwoByte regex JitCode or byteCode.

	Jan de Mooij [:jandem] Assignee
	Comment 4 • 10 years ago

Forgot to qref.

	Jan de Mooij [:jandem] Assignee
	Comment 6 • 10 years ago

Just enough changes to run some simple regexps. There are other places in irregexp that I have to fix, but I think I'll do that as part of fixing jit-tests/jstests.

	Brian Hackett [Laid off!]
	Comment 7 • 10 years ago

Comment on attachment 8441311 [details] [diff] [review]
Part 3 - Store Latin1/TwoByte code separately

Review of attachment 8441311 [details] [diff] [review]:
-----------------------------------------------------------------

Is isCompiled() used anywhere now?

	Brian Hackett [Laid off!]
	Comment 8 • 10 years ago

Comment on attachment 8441386 [details] [diff] [review]
Part 5 - Run regexps

Review of attachment 8441386 [details] [diff] [review]:
-----------------------------------------------------------------

I think irregexp::InterpretCode can GC via the interrupt callback.

	Jan de Mooij [:jandem] Assignee
	Comment 9 • 10 years ago

Parts 1 and 2:

https://hg.mozilla.org/integration/mozilla-inbound/rev/93ab210dd907
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0e518026f4b

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/93ab210dd907
https://hg.mozilla.org/mozilla-central/rev/b0e518026f4b

	Jan de Mooij [:jandem] Assignee
	Comment 11 • 10 years ago

Parts 3 and 4:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea0a96320d86
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd69b2caad20

(In reply to Brian Hackett (:bhackett) from comment #7)
> Is isCompiled() used anywhere now?

Yes, an assert in getParenCount: isCompiled() || canStringMatch.

	Jan de Mooij [:jandem] Assignee
	Comment 12 • 10 years ago

And part 5:

https://hg.mozilla.org/integration/mozilla-inbound/rev/4df3e4664b11

(In reply to Brian Hackett (:bhackett) from comment #8)
> I think irregexp::InterpretCode can GC via the interrupt callback.

Right, good catch! I changed it to use AutoStableStringChars instead for the regex interpreter.

	Ed Morley [:emorley]
	Comment 14 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/ea0a96320d86
https://hg.mozilla.org/mozilla-central/rev/bd69b2caad20

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 16 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/4df3e4664b11
https://hg.mozilla.org/mozilla-central/rev/14bc5bddd097

	Jan de Mooij [:jandem] Assignee
	Comment 17 • 10 years ago

Part 6:

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ca9a7a10ac4

	Ed Morley [:emorley]
	Comment 18 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/2ca9a7a10ac4

	Jan de Mooij [:jandem] Assignee
	Comment 19 • 10 years ago

V8 has the code below, but I think it's wrong. Latin1 char 0xff has an upper-case char outside the Latin1 range. This patch is more conservative just to be safe. I'll also see if I can write a testcase that fails with V8.

  if (!ascii_subject || character <= String::kMaxOneByteCharCode) {
    return length;
  }
  // The standard requires that non-ASCII characters cannot have ASCII
  // character codes in their equivalence class.
  return 0;

	Jan de Mooij [:jandem] Assignee
	Comment 20 • 10 years ago

OK, what V8 does is fine (see previous comment), because their FilterASCII code converts 0x178 to 0xff. This patch makes our FilterASCII and GetCaseIndependentLettersbehave work more like theirs, and the test I wrote passes with this.

	Jan de Mooij [:jandem] Assignee
	Comment 21 • 10 years ago

Parts 7 and 8:

https://hg.mozilla.org/integration/mozilla-inbound/rev/d77d20e48ffe
https://hg.mozilla.org/integration/mozilla-inbound/rev/efc771d4648c

	Jan de Mooij [:jandem] Assignee
	Comment 22 • 10 years ago

Fixes the last regex-related jit-test/jstest failures.

	Ryan VanderMeulen [:RyanVM]
	Comment 23 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/d77d20e48ffe
https://hg.mozilla.org/mozilla-central/rev/efc771d4648c

	Brian Hackett [Laid off!]
	Comment 24 • 10 years ago

Comment on attachment 8444299 [details] [diff] [review]
Part 9 - CheckNotBackReferenceIgnoreCase

Review of attachment 8444299 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/irregexp/NativeRegExpMacroAssembler.cpp
@@ +734,5 @@
> +        // Save register contents to make the registers available below. After
> +        // this, the temp0, backtrack_stack_pointer, and current_position
> +        // registers are available.
> +        masm.push(current_position);
> +        masm.push(backtrack_stack_pointer);

I think you can use temp2 (which v8's version doesn't have) to avoid one of these pushes.

	Jan de Mooij [:jandem] Assignee
	Comment 25 • 10 years ago

And part 9:

https://hg.mozilla.org/integration/mozilla-inbound/rev/61400645a576

(In reply to Brian Hackett (:bhackett) from comment #24)
> I think you can use temp2 (which v8's version doesn't have) to avoid one of
> these pushes.

Ah great, done.

	Ed Morley [:emorley]
	Comment 26 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/61400645a576