Closed
Bug 1029422
Opened 10 years ago
Closed 10 years ago
[PGO]Text rendering 50% slowdown on PGO build, regardless of font-family
Categories
(Core :: Web Painting, defect)
Tracking
()
RESOLVED
WORKSFORME
Tracking | Status | |
---|---|---|
firefox32 | --- | unaffected |
firefox33 | - | affected |
People
(Reporter: alice0775, Assigned: jandem)
References
Details
(Keywords: perf, regression)
Attachments
(1 file, 2 obsolete files)
(deleted),
text/html
|
Details |
Build Identifier: https://hg.mozilla.org/mozilla-central/rev/366b5c0c02d3 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140623030201 Steps To Reproduce: 1. Make sure "MS PGothic" is in your PC 2. Open attached Actual Results: Nightly 33.0a1 is 50 % slower than Aurora32.0a2 Expected Results: Should be same as Aurora32.0a2
Reporter | ||
Updated•10 years ago
|
Attachment #8445028 -
Attachment description: using "MS PGothic" → index.html using "MS PGothic"
Reporter | ||
Comment 1•10 years ago
|
||
This problem seems to happen only in PGO build(regular nightly and PGO build of tinderbox). Regression window(m-i PGO build) Good about 20fps: https://hg.mozilla.org/integration/mozilla-inbound/rev/bff872c9d4b2 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140619013007 Bad about 10 fps: https://hg.mozilla.org/integration/mozilla-inbound/rev/e589c195f61d Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140619043005 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=bff872c9d4b2&tochange=e589c195f61d
Summary: Text rendering 50% slowdown with "MS PGothic" which is default font on Japanese edition of Windows7 → [PGO]Text rendering 50% slowdown with "MS PGothic" which is default font on Japanese edition of Windows7
Reporter | ||
Comment 2•10 years ago
|
||
Attachment #8445028 -
Attachment is obsolete: true
Reporter | ||
Comment 3•10 years ago
|
||
This problem seems to happen regardless of font-family.
Reporter | ||
Comment 4•10 years ago
|
||
Suspect 4df3e4664b11 Jan de Mooij — Bug 1026438 part 5 - Make irregexp work with Latin1 strings.
Blocks: 1026438
Reporter | ||
Updated•10 years ago
|
Summary: [PGO]Text rendering 50% slowdown with "MS PGothic" which is default font on Japanese edition of Windows7 → [PGO]Text rendering 50% slowdown on PGO build, regardless of font-family
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Alice0775 White from comment #4) > Suspect > 4df3e4664b11 Jan de Mooij — Bug 1026438 part 5 - Make irregexp work with > Latin1 strings. I really doubt it; most of the changes I'm making won't have any effect until we turn on Latin1 strings by default. Also, a profile on OS X shows most of the time here is in graphics, and the website doesn't use regular expressions at all AFAICS. Nicolas, the only graphics-related bug I see in that range is bug 1027365, could it be related somehow? If needed we can do some PGO Try pushes to bisect this, but it will take a while.
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(nical.bugzilla)
Comment 7•10 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #5) > (In reply to Alice0775 White from comment #4) > Also, a profile on OS X shows most of the time here is in graphics, and the > website doesn't use regular expressions at all AFAICS. Nicolas, the only > graphics-related bug I see in that range is bug 1027365, could it be related > somehow? Bug 1027365 only affects video compositing, and more importantly it doesn't change anything on the configurations we already ship.
Flags: needinfo?(nical.bugzilla)
Reporter | ||
Comment 8•10 years ago
|
||
I would like to request to PGO try build of each changesets to find out regression. jdemooij@mozilla.com m_kato@ga2.so-net.ne.jp nical.bugzilla@gmail.com nicolas.b.pierron@mozilla.com brian@briansmith.org
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(m_kato)
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(jdemooij)
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(nical.bugzilla)
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(nicolas.b.pierron)
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(brian)
Comment 10•10 years ago
|
||
My commit (b1f5029982f2) definitely could not have changed the performance.
Flags: needinfo?(jwatt)
Assignee | ||
Comment 11•10 years ago
|
||
Alice, I started a Win32 PGO build for revision b1f5029982f2: https://tbpl.mozilla.org/?tree=Try&rev=163a89a8037a PGO builds take a long time, but when it's done can you try it? Then we can narrow it down further.
Comment 12•10 years ago
|
||
My changes didn't have anything to do with text rendering or graphics or anything except networking.
Flags: needinfo?(brian)
Comment 13•10 years ago
|
||
My landing is to fix compiler warning. If slow by me, JS benchmark becomes slow too. But since this depends on PGO, we may have to get all data per commit.
Flags: needinfo?(m_kato)
Comment 14•10 years ago
|
||
Both patches should be on Aurora (which is making PGO builds), can we reproduce this on Aurora after these patches? My guess is that they are extremely unlikely to cause any performance issue. d2152031a5d1 Bug 1022232 2bc6f38f9cff Bug 1011745
Flags: needinfo?(nicolas.b.pierron)
Assignee | ||
Comment 15•10 years ago
|
||
Did you have a chance to test the PGO build in comment 11?
Flags: needinfo?(jdemooij) → needinfo?(alice0775)
Reporter | ||
Comment 16•10 years ago
|
||
The tryserver build fixes the problem. :) https://hg.mozilla.org/try/rev/163a89a8037a Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140624110337
Flags: needinfo?(alice0775)
Reporter | ||
Comment 17•10 years ago
|
||
Today's Nightly33.0a1 seemed to recover to the level of the previous performance. https://hg.mozilla.org/mozilla-central/rev/83c09fe3a658 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140701030202 Progression window(m-i PGO) Bad(<10fps): https://hg.mozilla.org/integration/mozilla-inbound/rev/58bf8348c8f1 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140630043006 Good(>20fps): https://hg.mozilla.org/integration/mozilla-inbound/rev/b9954289176d Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140630073013 Progression pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=58bf8348c8f1&tochange=b9954289176d
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(nical.bugzilla)
Reporter | ||
Comment 18•10 years ago
|
||
It seems that Bug1028866 fixed the performance regression of PGO.
Updated•10 years ago
|
Assignee: nobody → jdemooij
Target Milestone: --- → mozilla33
Reporter | ||
Comment 19•10 years ago
|
||
The PGO regression appears again in tinderbox-builds/mozilla-inbound-win32-pgo build. Regression window Good: https://hg.mozilla.org/integration/mozilla-inbound/rev/ab2b0fb5cfff Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140714103003 Bad: https://hg.mozilla.org/integration/mozilla-inbound/rev/0f25f3ccb7b3 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140714133007 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ab2b0fb5cfff&tochange=0f25f3ccb7b3 Suspected: 0f25f3ccb7b3 Jan de Mooij — Bug 1037869 - Fix remaining Latin1 string issues. r=terrence
Blocks: 1037869
Status: RESOLVED → REOPENED
tracking-firefox33:
--- → ?
Resolution: FIXED → ---
Target Milestone: mozilla33 → ---
Reporter | ||
Comment 20•10 years ago
|
||
In my slow pc, the bad build is 50% slower than Good build. Steps To Reproduce: 1. Open attached 2. Wait until an alert box pops up Actual Results: 38000 msec Expected Results: 17000 msec
Reporter | ||
Updated•10 years ago
|
Attachment #8445064 -
Attachment is obsolete: true
Assignee | ||
Comment 21•10 years ago
|
||
Alice, would you mind trying this build: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jandemooij@gmail.com-8e89e911813c/try-win32/ What numbers do you get? (This is with the PGO patch in bug 1030706.)
Reporter | ||
Comment 22•10 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #21) > Alice, would you mind trying this build: > > http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jandemooij@gmail. > com-8e89e911813c/try-win32/ > > What numbers do you get? (This is with the PGO patch in bug 1030706.) I got 17354 ms The try build fixes the performance problem :) https://hg.mozilla.org/try/rev/8e89e911813c Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140715031024
Assignee | ||
Comment 23•10 years ago
|
||
(In reply to Alice0775 White from comment #22) > I got 17354 ms > The try build fixes the performance problem :) Thanks for checking!
Reporter | ||
Comment 25•10 years ago
|
||
The performance is back. I cannot reproduce the performance problem in the following today's Nightly33.0a1. https://hg.mozilla.org/mozilla-central/rev/a74600665875 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140717030339
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → WORKSFORME
Updated•10 years ago
|
Updated•6 years ago
|
Component: Layout: View Rendering → Layout: Web Painting
You need to log in
before you can comment on or make changes to this bug.
Description
•