Closed
Bug 1028143
Opened 10 years ago
Closed 10 years ago
Remove dangerous public destructor of MediaPipeline
Categories
(Core :: WebRTC: Signaling, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: bjacob, Assigned: anujagarwal464)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jesup
:
review+
mccr8
:
feedback+
|
Details | Diff | Splinter Review |
In bug 1027251 we removed all dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.
One of them is: MediaPipeline
Flags: needinfo?(rjesup)
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → anujagarwal464
Attachment #8454916 -
Flags: feedback?(bjacob)
Reporter | ||
Comment 2•10 years ago
|
||
Comment on attachment 8454916 [details] [diff] [review]
bug1028143.diff
Review of attachment 8454916 [details] [diff] [review]:
-----------------------------------------------------------------
Same comment as on bug 1028142. I expected this to be not quite so trivial, but I could of course have been wrong.
Attachment #8454916 -
Flags: feedback?(bjacob) → feedback+
Assignee | ||
Updated•10 years ago
|
Attachment #8454916 -
Flags: feedback+ → feedback?(continuation)
Assignee | ||
Comment 3•10 years ago
|
||
@Andrew: Try run was green
https://tbpl.mozilla.org/?tree=Try&rev=f064e98faf66
Comment 4•10 years ago
|
||
Comment on attachment 8454916 [details] [diff] [review]
bug1028143.diff
Review of attachment 8454916 [details] [diff] [review]:
-----------------------------------------------------------------
This looks fine to me. It seems odd that it wasn't fixed before, but this code may have just changed around in the last few months.
Attachment #8454916 -
Flags: review?(rjesup)
Attachment #8454916 -
Flags: feedback?(continuation)
Attachment #8454916 -
Flags: feedback+
Updated•10 years ago
|
Flags: needinfo?(rjesup)
Updated•10 years ago
|
Attachment #8454916 -
Flags: review?(rjesup) → review+
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
Keywords: checkin-needed
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•