Closed Bug 1032069 Opened 10 years ago Closed 10 years ago

[Bluetooth] Refactor BT app to make it embed-able from Settings app

Categories

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S1 (1aug)

People

(Reporter: eragonj, Assigned: iliu)

References

Details

(Whiteboard: [p=5])

Attachments

(1 file)

We have to refactor BT app to make sure it is embed-able from Settings app. We need this change because we don't want to maintain two similar codes between Settings app & BT app.
Status: NEW → ASSIGNED
Attached file WIP 21390 (deleted) —
A WIP for our refactor gaol. We can do following steps to make Bluetooth app running as an app from home screen. * remove "type": "certified" from manifest * add ["apps", "bluetooth"] in homescreen/build/default-homescreens.json * add ["apps", "bluetooth"] in verticalhome/build/default-homescreens.json
Whiteboard: [p=5]
Target Milestone: --- → 2.0 S6 (18july)
Per offline discussion for fixing embedded iframe issue, updated the WIP.
Blocks: 1037306
Looks like that window.alert(), window.confirm(), window.prompt() not work in the embedded iframe. We keep to fix the issue in settings app.
Target Milestone: 2.0 S6 (18july) → 2.1 S1 (1aug)
Comment on attachment 8450895 [details] WIP 21390 Hi Arthur, per offline discussion with porting issue, EJ have fixed window.xxx(); via bug 1033951. I think we could let the patch in reviewing state. Could you please help to review? Thanks. Major change: * Move Settings::bluetooth.js to Bluetooth app(rename with settings.js) * Use settings key "bluetooth.device.connected" to maintain connected device * Manifest change * Will need to keep updating CSS style until we land the patch
Attachment #8450895 - Flags: review?(arthur.chen)
Comment on attachment 8450895 [details] WIP 21390 r=me with the nits addressed, thank you!
Attachment #8450895 - Flags: review?(arthur.chen) → review+
Thanks for Arthur's reviewing effort. Since the pr is landed, we can close the issue now. Gaia/master: 019669228af17bbd0e6001eacb33c80eb0a0ee29
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: