Timestamp: 01/07/14 13:09:53 Error: listManager.setUpdateUrl is not a function Source File: file:///Users/javierrueda/comm-central/obj-x86_64-apple-darwin13.2.0/mozilla/dist/Daily.app/Contents/MacOS/components/nsPhishingProtectionApplication.js Line: 156 Function setUpdateUrl() was removed on bug 1021419: https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1021419&attachment=8446724 Above error is appearing now on Error Console.

Confirmed using Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Thunderbird/33.0a1 (Application Build ID: 20140721030207).

This error message is very annoying while investigating other test failures. We need to change our codes to adapt new APIs.

On top of attachment 8570391 [details] [diff] [review], which made TB run further, I needed to add the uploaded change to shut up the following error which subsequently appeared. unable to create the phishing warden: [Exception... "Not enough arguments [nsIUrlListManager.registerTable]" nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)" location: "JS frame :: file:///REF-OBJ-DIR/objdir-tb3/dist/bin/components/nsPhishingProtectionApplication.js :: PROT_ListWarden.prototype.registerWhiteTable :: line 358" data: no] I think the list API change may have more impacts which we may uncover when the C-C tree is in better shape (compilable and run without crash). TIA

(In reply to ISHIKAWA, Chiaki from comment #3) > Created attachment 8507508 [details] [diff] [review] > A few more changes necessary to reduce errors. > > On top of attachment 8570391 [details] [diff] [review], which made TB run further, > I needed to add the uploaded change to shut up the following error which > subsequently appeared. Yes, I know it. But another bug has been open for it. Please attach the patch in the another bug.

(In reply to Hiroyuki Ikezoe (:hiro) from comment #4) > Yes, I know it. But another bug has been open for it. Please attach the > patch in the another bug. Can you kindly tell me which bugzilla is it? I searched for |registerTable| and can't find it. Is the search window on top of this page, not useful for text search? TIA

(In reply to ISHIKAWA, Chiaki from comment #5) > (In reply to Hiroyuki Ikezoe (:hiro) from comment #4) > > > Yes, I know it. But another bug has been open for it. Please attach the > > patch in the another bug. > > Can you kindly tell me which bugzilla is it? I am sorry. That was a closed bug. Bug 813691. Anyway what I meant to say was please post to proper bug. Or please change title of bug first if you want to reuse existence bug.

(In reply to Hiroyuki Ikezoe (:hiro) from comment #6) > (In reply to ISHIKAWA, Chiaki from comment #5) > > (In reply to Hiroyuki Ikezoe (:hiro) from comment #4) > > > > > Yes, I know it. But another bug has been open for it. Please attach the > > > patch in the another bug. > > > > Can you kindly tell me which bugzilla is it? > > I am sorry. That was a closed bug. Bug 813691. > Anyway what I meant to say was please post to proper bug. Or please change > title of bug first if you want to reuse existence bug. OK, I understand. But I am not sure what to do here. Since the patch https://bugzilla.mozilla.org/attachment.cgi?id=8507391 (Possible Fix) deal with one issue (listManager.setUpdateUrl), and mine deals with the different # of arguments issue (registerTable), I think it would be proper to file a different bugzilla entry. So I will do this. Strange, no issues happened around the time Bug 813691 happened, but I suppose more API changes were introduced very lately. TIA

Hiro, thanks for looking at this annoying error.

Please check Bug 1085382 in which removal of files under /phishing directory is now discussed. TIA

Thanks, I already took a look the bug.