Closed
Bug 1035508
Opened 10 years ago
Closed 10 years ago
"mach jetpack-test" doesn't run any tests
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: mossop, Assigned: mossop)
References
Details
Attachments
(1 file)
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Launches Firefox but says "No tests were run" :(
Might be a simple fix in the mach command file, might need to wait for mochitestification.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → dtownsend+bugmail
Assignee | ||
Comment 1•10 years ago
|
||
Bug 1031328 means we have to be in the right directory when we run the tests. Probably easier to fix it here than there since we're looking into replacing our test harness.
Attachment #8452708 -
Flags: review?(gps)
Comment 2•10 years ago
|
||
Comment on attachment 8452708 [details] [diff] [review]
patch
Review of attachment 8452708 [details] [diff] [review]:
-----------------------------------------------------------------
::: testing/testsuite-targets.mk
@@ +378,5 @@
> echo 'please prepare your host with environment variables for TEST_DEVICE'; \
> fi
>
> jetpack-tests:
> + cd $(topsrcdir)/addon-sdk/source && $(PYTHON) bin/cfx -b $(realpath $(browser_path)) --parseable testpkgs
$(abspath) is a better choice here. $(realpath) does symlink expansion, etc. You don't typically use $(realpath) unless you are testing whether two paths are the same.
Attachment #8452708 -
Flags: review?(gps) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Priority: -- → P1
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•