This is a partial breakdown of bug 1009760. I thought it would be really simple to get a crash ID into GMPParent::ActorDestroy and I was quite wrong. Most of the problems are related to the fact that GMPParent doesn't live on the main thread, so many of the support functions that would normally just work need adjustment. But I think I have it working!

Followup, need to always return from this method. Should be folded in before landing.

Comment on attachment 8456972 [details] [diff] [review] bug1039575 Review of attachment 8456972 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/gmp/GMPParent.cpp @@ +254,5 @@ > +#ifdef MOZ_CRASHREPORTER > +void > +GMPParent::WriteExtraDataForMinidump(CrashReporter::AnnotationTable& notes) > +{ > + notes.Put(NS_LITERAL_CSTRING("GMPPlugin"), NS_LITERAL_CSTRING("1")); Oh, well, this answered my question from the other review... @@ +287,5 @@ > void > GMPParent::ActorDestroy(ActorDestroyReason aWhy) > { > + if (AbnormalShutdown == aWhy) { > + nsString dumpID; You should put this inside the ifdef.

And !MOZ_CRASHREPORTER bustage fix: https://hg.mozilla.org/integration/mozilla-inbound/rev/bdd82f1bf313

https://hg.mozilla.org/mozilla-central/rev/55762bee8f27 https://hg.mozilla.org/mozilla-central/rev/bdd82f1bf313