Closed
Bug 1039579
Opened 10 years ago
Closed 10 years ago
CrashReporterParent::NotifyCrashService should always be on the main thread
Categories
(Toolkit :: Crash Reporting, defect)
Tracking
()
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Currently CrashReporterParent assumes that crashes are notified on the main thread, which is true for content/plugins, but is not true of GMP plugins where the entire IPDL setup is on the GMP thread.
The patch here will just proxy the crash-manager bits to the main thread.
Flags: firefox-backlog+
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8456970 -
Flags: review?(ted)
Updated•10 years ago
|
Attachment #8456970 -
Attachment is patch: true
Comment 2•10 years ago
|
||
Comment on attachment 8456970 [details] [diff] [review]
bug1039579-CrashReporterParent
Review of attachment 8456970 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/ipc/CrashReporterParent.cpp
@@ +120,1 @@
> type = NS_LITERAL_CSTRING("plugin");
Do we want any additional annotation here or do we think it'll be obvious from the other context in the crash report?
@@ +152,5 @@
> + }
> + private:
> + CrashReporterParent* mCR;
> + };
> + SyncRunnable::DispatchToThread(mainThread, new NotifyOnMainThread(this));
Is this just an expensive no-op if this is already being called on the main thread? (Shouldn't matter, this isn't perf-sensitive code.)
Attachment #8456970 -
Flags: review?(ted) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Target Milestone: --- → mozilla33
Assignee | ||
Updated•10 years ago
|
QA Whiteboard: [qa-]
Updated•10 years ago
|
Iteration: --- → 33.3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•