Closed
Bug 1040060
Opened 10 years ago
Closed 6 years ago
Move GMPInstallManager front end code from delayed-startup+delay to final-ui-startup+delay
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: bbondy, Unassigned)
References
(Blocks 4 open bugs)
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
gfritzsche
:
review+
|
Details | Diff | Splinter Review |
Yoric suggested that a better place for this to live is final-ui-startup+delay This is only for the 4 lines of code in browser.js currently.
|
||
Updated•10 years ago
|
Flags: firefox-backlog+
|
||
Updated•10 years ago
|
Flags: needinfo?(dteller)
|
Reporter | |
Comment 1•10 years ago
|
||
Clearing needinfo, I had emailed dteller and he tipped me off on Timer.jsm which was the module I needed for the early startup timer.
Attachment #8468495 -
Flags: review?(georg.fritzsche)
Flags: needinfo?(dteller)
|
|
Reporter | |
Comment 2•10 years ago
|
||
Correct patch
Attachment #8468495 -
Attachment is obsolete: true
Attachment #8468495 -
Flags: review?(georg.fritzsche)
Attachment #8468497 -
Flags: review?(georg.fritzsche)
|
|
Reporter | |
Comment 3•10 years ago
|
||
Attachment #8468497 -
Attachment is obsolete: true
Attachment #8468497 -
Flags: review?(georg.fritzsche)
Attachment #8468500 -
Flags: review?(georg.fritzsche)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8468500 [details] [diff] [review] Patch v1. Review of attachment 8468500 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/nsBrowserGlue.js @@ +521,5 @@ > > + // Delay this a minute because there's no rush > + setTimeout(() => { > + this.gmpInstallManager = new GMPInstallManager(); > + // We don't really care about the results, if somenoe is interested they Let's fix the typo while we're at it.
Attachment #8468500 -
Flags: review?(georg.fritzsche) → review+
|
|
Reporter | |
Updated•10 years ago
|
Assignee: netzen → nobody
|
||
Comment 5•6 years ago
|
||
Bug 1388145 moved this initialization to the right place.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•