Closed
Bug 1041833
Opened 10 years ago
Closed 9 years ago
Enable CSSOM-View smooth scrolling for Android
Categories
(Firefox for Android Graveyard :: Toolbar, defect)
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: kip, Assigned: rbarker)
References
()
Details
Attachments
(1 file)
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
Before CSSOM-View Scroll-Behavior can be enabled for Firefox for Android, JavaPanZoomController (and possibly others) must be updated.
- Scroll events must cancel CSSOM-View smooth scroll animations
- Fling gestures must not cancel CSSOM-View smooth scroll animations that are started during the deceleration; the CSSOM-View smooth scroll position updates must preempt the fling gesture deceleration position updates.
See the patch set of Bug 1022825 for examples of how this may be integrated.
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → kgilbert
Comment 1•10 years ago
|
||
I think it would probably be better to just switch Fennec over to using the C++ APZC code than to have yet another binding for the smooth scrolling code. Bug 776030 is tracking that work, and I think we're actually in pretty good shape to be able to implement that soon.
Comment 2•10 years ago
|
||
Yes please (to bug 776030) - we have to reduce the number of code paths we take.
Reporter | ||
Updated•10 years ago
|
Depends on: apz-fennec
Reporter | ||
Updated•10 years ago
|
Reporter | ||
Comment 3•10 years ago
|
||
Once Bug 776030 lands, CSSOM-View scroll-behavior smooth scrolling should be tested on Fennec. Once its confirmed working, then the preferences to enable the CSSOM-View scroll-behavior property and DOM method extensions should be enabled for Fennec by default:
layout.css.scroll-behavior.enabled
layout.css.scroll-behavior.property-enabled
Summary: Implement CSSOM-View smooth scrolling for Android → Enable CSSOM-View smooth scrolling for Android
Comment 4•9 years ago
|
||
Now that we have APZ enabled on nightly we should turn this on as well and make sure it works well.
Blocks: fennec-aboard-apz
No longer depends on: apz-fennec
Assignee | ||
Comment 5•9 years ago
|
||
Comment 6•9 years ago
|
||
Test page : https://staktrace.com/resources/extras/spout/scroll-behavior.html
Without smooth scrolling it jumps to the bottom with smooth scrolling it should scroll down in an animation
Comment 7•9 years ago
|
||
Comment on attachment 8697585 [details] [diff] [review]
0001-Bug-1041833-Enable-CSSOM-View-smooth-scrolling-for-Android-15121111-b9634be.patch
Review of attachment 8697585 [details] [diff] [review]:
-----------------------------------------------------------------
I think the prefs should be true on every other platform already so you should be able to just make it true unconditionally and remove it from any platform-specific pref files.
Comment 8•9 years ago
|
||
Actually ignore comment 7. It's not enabled on b2g. So land your stuff and I can file another bug to clean it up and enable it on b2g (which I assume is an oversight).
Assignee | ||
Comment 9•9 years ago
|
||
Assignee | ||
Comment 10•9 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #8)
> Actually ignore comment 7. It's not enabled on b2g. So land your stuff and I
> can file another bug to clean it up and enable it on b2g (which I assume is
> an oversight).
What about Fennec with JPZ? I assume that should also remain disabled?
Assignee | ||
Updated•9 years ago
|
Assignee: kgilbert → rbarker
Assignee | ||
Updated•9 years ago
|
Attachment #8697585 -
Flags: review?(snorp)
Comment 11•9 years ago
|
||
Yeah it should remain disabled with JPZ.
Attachment #8697585 -
Flags: review?(snorp) → review+
Comment 12•9 years ago
|
||
Comment 13•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•