Closed Bug 1042695 Opened 10 years ago Closed 10 years ago

Comment left by treeherder-to-TBPL-sync omits the bug number

Categories

(Tree Management :: Treeherder, defect, P1)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: mdoglio)

References

Details

Classifying a failure on treeherder successfully leaves a comment on TBPL for the same job (nice work!).

The comment left on TBPL is:
intermittent

Please could we make it something like:
Bug 123456 (classification: intermittent)

And for multiple bugs:
Bug 123456, Bug 654321 (classification: intermittent)
It seems like this is already meant to happen?
https://github.com/mozilla/treeherder-service/blob/a0d82137ccc519ed1036ee12e25238ed012b9994/treeherder/etl/tbpl.py#L95
Summary: Comment left by treeherder to TBPL sync needs tweaking → Comment left by treeherder-to-TBPL-sync needs tweaking
Summary: Comment left by treeherder-to-TBPL-sync needs tweaking → Comment left by treeherder-to-TBPL-sync omits the bug number
Assignee: nobody → mdoglio
Status: NEW → ASSIGNED
Mauro - don't suppose you've had any luck with this P1?
It's one of the reasons I'm not actively using treeherder side-by-side with TBPL, since the synced data isn't correct.
It's the next item on my list. I'll work on it tomorrow probably
Ah great :-)
Quick update on the progress: persona authentication is not working properly and that prevents the bug submission to tbpl. A quick workaround is to logout and login again with persona. I will open a bug for it and mark this as dependent.
I forgot to mention that there was an outdated permission check on the bug association endpoint that checked if the user submitting data is a sheriff. I'll remove it in a mini PR
Depends on: 1050765
It's on master now, I'll apply it to production in a few hours. I also marked bug 1050765 as a blocker for this
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Was it intended that there are now two comments left, one that says "intermittent" and one that has the bug number?

eg:
https://tbpl.mozilla.org/?rev=8252eae8278c&jobname=Ubuntu%20ASAN%20VM%2012.04%20x64%20mozilla-central%20opt%20test%20mochitest-devtools-chrome
Flags: needinfo?(mdoglio)
Yes, that's due to the differentiation between bug association and classification we do on treeherder. If it's a problem I can avoid posting the classification to tbpl unless there is a comment attached to it
Flags: needinfo?(mdoglio)
Let's perhaps just leave as is, not doing any harm & we'll only be throwing away the sync code in a while :-)
You need to log in before you can comment on or make changes to this bug.