User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release) Build ID: 20140715214327 Steps to reproduce: 2 Issues First one received an invitation and no button are showing Second one People respond to my invitation but the update button is not shown in the imip bar I am on Linux (Kubuntu 14.04) with both thunderbird and Lightning coming from ubuntu Actual results: 1. No buttons are showing for Accept Decline or Tentative. i have the following errors showing in the console [JavaScript Error: "[Exception... "[JavaScript Error: "data[("button" + i)] is undefined" {file: "resource://conversations/modules/plugins/lightning.js" line: 108}]'[JavaScript Error: "data[("button" + i)] is undefined" {file: "resource://conversations/modules/plugins/lightning.js" line: 108}]' when calling method: [calIOperationListener::onOperationComplete]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: file:///usr/lib/thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calCompositeCalendar.js :: calCompositeGetListenerHelper.prototype.onOperationComplete :: line 520" data: yes]"] Timestamp: 23/07/14 17:20:48 Error: data[("button" + i)] is undefined Source File: resource://conversations/modules/plugins/lightning.js Line: 108 2. No buttons to update the event with status of the attendees Expected results: 1. Buttons to accept decline or tentative 2. Button to update

According to the error message it is caused by an extension called "conversations". Could you please retest after disabling this extension?

Maybe the failing extension is "Thunderbird Conversations".

Does the latest version of conversations at http://jonathan.xulforum.org/files/gcv-nightlies/ fix the issue?

Hello Thanks for the quick response. Removing conversations does the trick and the latest version does fix the issue Thank again for your help

Sorry the latest version of conversation does NOT fix the issue sorry

The error message with latest version of conversations Timestamp: 25/07/14 14:10:51 Error: data[("button" + i)] is undefined Source File: resource://conversations/modules/plugins/lightning.js Line: 108 Timestamp: 25/07/14 14:10:51 Error: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "data[("button" + i)] is undefined" {file: "resource://conversations/modules/plugins/lightning.js" line: 108}]'[JavaScript Error: "data[("button" + i)] is undefined" {file: "resource://conversations/modules/plugins/lightning.js" line: 108}]' when calling method: [calIOperationListener::onOperationComplete] Source File: file:///usr/lib/thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calCompositeCalendar.js Line: 520 [JavaScript Error: "[Exception... "[JavaScript Error: "data[("button" + i)] is undefined" {file: "resource://conversations/modules/plugins/lightning.js" line: 108}]'[JavaScript Error: "data[("button" + i)] is undefined" {file: "resource://conversations/modules/plugins/lightning.js" line: 108}]' when calling method: [calIOperationListener::onOperationComplete]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: file:///usr/lib/thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calCompositeCalendar.js :: calCompositeGetListenerHelper.prototype.onOperationComplete :: line 520" data: yes]"] Hope this help to debug

Imip bar button implementation of Lightning has changed with bug 990009. This needs to be fixed at Thunderbird Conversations end.

Jonathan, can you take a look into this? I bet you just have to change a few IDs and button types.

Hello Jonathan I think Changing the line 107 on lighthning.js should be ok to let buttonElement = rootNode.getElementsById("imip-button" + i)[0]; I am not able to repackage it as xpi but this should do the trick

Thanks for the hint! I'll look into it as soon as I can :)

Quite a few changes happened in bug 990009 regarding how buttons work in the imip bar. Currently reading through the diff to figure out how to update the Conversations plugin accordingly.

Hi, I've uploaded an updated version of Conversations at http://jonathan.xulforum.org/files/gcv-nightlies/201407311428-master.xpi which offers basic support for accept/decline. Since I'm not an active user of Lightning, I would definitely need feedback on the interface. In particular, the HTML interface of Conversations offers no way to have dropdown buttons, so (please correct me if I'm wrong): - I need to disable the "more" button, - I need to enable the "tentative accept" button whenever the "accept button" is enabled. Philipp, if that's the right way to go, I'll proceed and fix the two items above. There was a lot of buttons in the XUL interface, so I copy/pasted all of them in case they were useful, but it seems like only accept, decline and more are enabled. Is that correct? Cheers, ~ jonathan

Hi Jonathan I have tested it and it seems to work at least for the buttons as theyr were before so ...it is a good step forward. Just out of curiosity was the hint useful? Thanks a lot

No, the hint was not really useful, because the class name was correct, as it was referring to the elements defined _inside_ the Conversations UI, which you can see here https://github.com/protz/GMail-Conversation-View/blob/master/content/stub.xhtml#L888 But thanks anyway :)

I was able to download your nightly build with the fix for this issue and install it. The buttons for accepting new calendar invitations are now working properly. However, when a message containing an event cancellation arrives, no buttons are shown to remove it from the calendar.

Can you send me a test message for that? I don't have any in my test suite. Thanks, ~ jonathan

MakeMyDay, can you reply to comment 13? I think it should be fine given the restriction there is no dropdown menu and will at least provide the same options as before, but ideally Conversations should support dropdown buttons :-)

Sure. First of all, I'm not a user of the Conversations, so I'm not familiar with how it works. > I've uploaded an updated version of Conversations at > http://jonathan.xulforum.org/files/gcv-nightlies/201407311428-master.xpi > which offers basic support for accept/decline. Since I'm not an active user > of Lightning, I would definitely need feedback on the interface. In > particular, the HTML interface of Conversations offers no way to have > dropdown buttons, so (please correct me if I'm wrong): > - I need to disable the "more" button, > - I need to enable the "tentative accept" button whenever the "accept > button" is enabled. For the 3.3.x release of Lightning this might be an appropriate way to go. The more button is not needed in this release and you can stay with the well known 3 button approach for incoming invitations without cutting off functionality (Lightning itself adopts the button type dynamically, what ends up still in simple buttons for now). Keep in mind, that Lightning distincts between single events and recurring events and uses separate buttons respectively. Beside the buttons for incoming invitations and except the more button, you should also support the other single buttons (delete, add, update, details and re-confirm) to avoid expiriences like in comment #16. > There was a lot of buttons in the XUL interface, so I copy/pasted all of > them in case they were useful, but it seems like only accept, decline and > more are enabled. Is that correct? If you copy over the xul code, use the version from HG and not from the original patch - there have been strings changes subsequently. Nevertheless, to avoid cutting off functionality in future releases or being forced to heavily work around, you should consider to implement dropdown buttons (see example image in bug 990009) mid-term. The dropdown functionality will be used in the next ESR release - the current nightly does already partly - to provide more options to deal with invitations. I hope this helps so far.

For reference: the issue from comment #16 is probably not a Conversation problem, but bug 1047227.

Alright, the issue has been fixed in Conversations by https://github.com/protz/GMail-Conversation-View/commit/914eff9fb565d5590df15181849e3f28b3cb2170 ; it implements the solution I described in comment #13. The issue with the "cancel" button remains; this is bug 1047227. (In reply to MakeMyDay from comment #19) > > For the 3.3.x release of Lightning this might be an appropriate way to go. > The more button is not needed in this release and you can stay with the well > known 3 button approach for incoming invitations without cutting off > functionality (Lightning itself adopts the button type dynamically, what > ends up still in simple buttons for now). (This is what I did) > Beside the buttons for incoming invitations and except the more button, you should also support the other single buttons (delete, add, update, details and re-confirm) to avoid expiriences like in comment #16. I'm calling cal.itip.getOptionsText, so I'm honoring what the standard Lightning code decides, i.e. I'm showing the buttons that Lightning says should be shown. > > Nevertheless, to avoid cutting off functionality in future releases or being > forced to heavily work around, you should consider to implement dropdown > buttons (see example image in bug 990009) mid-term. The dropdown > functionality will be used in the next ESR release - the current nightly > does already partly - to provide more options to deal with invitations. Unfortunately, the Conversations UI is HTML, so there's no support for dropdown buttons. I could use xul: namespaced items inside HTML (this is technically feasible); however, the (outdated) templating enging (jquery-tmpl) that I'm using does not allow me to do that. This is definitely due for a refresh. > I hope this helps so far. Sure, it does. Thanks much for the information.

(A build with the fix is available at http://jonathan.xulforum.org/files/gcv-nightlies/201408041650-master.xpi)