Closed Bug 1043345 Opened 10 years ago Closed 8 years ago

Better control over revision links for PRs (where the revision lives in another repo)

Categories

(Tree Management :: Treeherder: API, defect, P5)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: emorley, Unassigned)

Details

Migrated from: https://github.com/mozilla/treeherder-service/issues/113 lightsofapollo commented on 27 Feb: { Would it be possible to get more control over revision links? For pull requests the revisions live in the submitters repo not in gaia itself so urls. Not sure how easy this is but having direct access to just set the revision url would be ideal (github provides a html links by default so its really trivial to pass it) } jeads commented on 27 Feb: { I think this would be fairly easy to support. Would the desired behavior be passing in the revision link in the resultset json structure like so? 'revisions': [ { 'comment': 'Bug 936711 - Fix crash which happened at disabling Bluetooth...', 'files': [ 'dom/bluetooth/BluetoothA2dpManager.cpp', 'dom/bluetooth/BluetoothHidManager.cpp', 'dom/bluetooth/linux/BluetoothDBusService.cpp' ], 'revision': 'cdfe03e77e66', 'url':'https://github.com/somepersonsrepository', 'repository': 'test_treeherder', 'author': 'Some Person <sperson@someplace.com>' }, If so I think we could support that by adding a url column to https://github.com/mozilla/treeherder-service/blob/master/treeherder/model/sql/template_schema/project_jobs_1.sql.tmpl#L309 and this would be used in the UI for the link. We could have default handling to use the one set for the repository if the revision specific url is not present. We also need some handling in the UI to deal with full length revision hashes, this isn't a problem with the gecko repositories because we have to truncate the revisions in the etl process to get them to match across the disparate data sources available through buildbot. Easy to do... } lightsofapollo commented on 27 Feb: { @jeads Yeah that sounds good... one minor clarification in your example the url is https://github.com/somepersonsrepository (which could be meant as a relative path that we add the revision to) I would ideally like url to accept whatever input we give it without modification (which is what I think you mean?) } jeads commented on 28 Feb: { Yeah, that's what I meant but that's not reflected in the url example I gave. If the url property is present in the json we will use it without any modification and assume it will get us to the final target destination for the revision provided. }
Priority: P3 → P4
No longer blocks: 1072676
Component: Treeherder → Treeherder: API
Priority: P4 → P5
I don't think this is relevant any more now that we ingest from GitHub using Pulse.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.