Currently c-c is broken following the landing of Bug 1043344. The errors you get are similar to: make: Entering an unknown directory make: *** mailnews/import/src: No such file or directory. Stop. make: Leaving an unknown directory make[4]: *** [mailnews/import/src/target] Error 2

I did try and keep the patch as small as possible, but as I fixed each issue the size grew. This includes the fix to bug 1045484 as well. It isn't finished yet as it falls over because it does not pick up mailnews/intl as needing to be an export_dir My .mozconfig is: export CC=clang export CXX=clang++ mk_add_options MOZ_CO_PROJECT=suite ac_add_options --enable-application=suite ac_add_options --enable-calendar ac_add_options --enable-debugger-info-modules="yes" mk_add_options MOZ_OBJDIR=/home/gizmo/central/c-c/obj-sm ac_add_options --enable-optimizer="-O2 -gstabs+" mk_add_options MOZ_MAKE_FLAGS="-j4" ac_add_options --with-ccache=/usr/bin/ccache

Comment on attachment 8464419 [details] [diff] [review] Port lots of changes from m-c build system (WIP) keeping joshua in the loop and a chance to provide *early* feedback

Comment on attachment 8464419 [details] [diff] [review] Port lots of changes from m-c build system (WIP) I'm already in the loop, but I'm in no position to do any patch reviews.

This patch, along with the fixes on bug 1045969 and bug 1046468, does generate a working SeaMonkey and Thunderbird build for me. I've not tested other c-c based applications or L10n at this point. Potentially there is stuff that is not needed or other stuff that is needed, but at least it is a working starting point :)

Pushed to try - https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=24233e5b4987

(In reply to Ian Neal from comment #5) > Pushed to try - > https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=24233e5b4987 Okay, bustage is due to landing of bug 1044162 I'll look at sorting that out tomorrow.

Comment on attachment 8465149 [details] [diff] [review] Unbitrotted working patch [Checked in: Comment 10] Review of attachment 8465149 [details] [diff] [review]: ----------------------------------------------------------------- This looks reasonable, I haven't done an indepth review, but assumed you've ported things across nicely.

Pushed again to try with fix to bug 1046638 as well: https://hg.mozilla.org/try-comm-central/rev/a919fb83f070

Comment on attachment 8465149 [details] [diff] [review] Unbitrotted working patch [Checked in: Comment 10] https://hg.mozilla.org/comm-central/rev/f200e20f0ea9

<RattyAway> Error: c:\t1\hg\objdir-sm\suite\installer\package-manifest:378: Missing file(s): bin/extensions/modern@themes.mozilla.org.xpi Error: c:\t1\hg\objdir-sm\suite\installer\package-manifest:569: Missing file(s): bin/distribution/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}.xpi etc IanN: make package failed extensions in bin\extensions\ are unpacked. <RattyAway> there is no bin\distributions\ ... <NeilAway> RattyAway: extensions are supposed to be unpacked in a regular build RattyAway: make -C $objdir/suite/app pack-ext packages them <IanN> the build i have recently created from a patched c-c, has both chatzilla and inspector xpis but not a lightning one :( ... (RattyAway runs: make -C $objdir/suite/app pack-ext ... generates packed XPI's) NeilAway: ok now I've only got one error on make package: Error: c:\t1\hg\objdir-sm\suite\installer\package-manifest:575: Missing file(s): bin/distribution/extensions/debugQA@mozilla.org.xpi NeilAway: Makefile says: ifdef MOZ_OMNIJAR # Make extensions end up as XPIs instead of flat chrome when doing omni.jar. (RattyAway runs: mozmake -j6 -C ../objdir-sm/suite/debugQA/) This generates an unpacked bin/distribution/extensions/debugQA@mozilla.org ... OK running make -C $objdir/suite/app again generates a packed debugQA@mozilla.org.xpi ... tools:: @$(MAKE) pack-ext STAGEDIST="$(DIST)/bin" <RattyAway> NeilAway: didn't glandium do away with tools? aha Bug 1043802 - Remove TOOLS_DIRS and TEST_TOOLS_DIRS

So Bug 1047702 covers the build system not searching comm-central for tools, XPI_PKGNAME, etc and Bug 1047924 covers the build system not putting extensions in the right places under dist/bin