Closed Bug 1047702 Opened 10 years ago Closed 10 years ago

recursivemake's scan for Makefiles with XPI_PKGNAME or INSTALL_EXTENSION_ID should take account of comm-central

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Keywords: dogfood, regression)

Attachments

(1 file, 1 obsolete file)

Recursivemake tools fix v2
(deleted), patch
iannbugzilla
: review+
Details | Diff | Splinter Review
Attached patch Recursivemake tools fix (obsolete) (deleted) — — Splinter Review
Since the patch from bug 1043344 landed directories in comm-central are not being traversed whilst looking for Makefile containing a tools target, or XPI_PKGNAME or INSTALL_EXTENSION_ID. This patch applies a similar fix to that in Bug 1045329
Attachment #8466529 - Flags: review?(mshal)
Comment on attachment 8466529 [details] [diff] [review] Recursivemake tools fix I can confirm that this patch fixes the Instantbird builds on Mac.
Attachment #8466529 - Flags: feedback+
Attachment #8466529 - Flags: review?(mshal) → review+
Comment on attachment 8466529 [details] [diff] [review] Recursivemake tools fix Review of attachment 8466529 [details] [diff] [review]: ----------------------------------------------------------------- ::: python/mozbuild/mozbuild/backend/recursivemake.py @@ +732,5 @@ > if t not in content: > continue > if t == b'tools' and not re.search('(?:^|\s)tools.*::', content, re.M): > continue > if objdir == bf.environment.topobjdir: You can also change this one.
Attached patch Recursivemake tools fix v2 (deleted) — — Splinter Review
Carrying forward r+
Attachment #8466529 - Attachment is obsolete: true
Attachment #8466564 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/2f0e480f298c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: