Jan Keromnes [:janx] Reporter
	Description • 10 years ago

When the DevTools theme is set to "Dark theme", the toolbox and the editors inside it are dark.

This doesn't look good with the all-light WebIDE. Its menus, panels and editors should become dark as well, making the "DevTools theme" setting work across all devtools.

	Brian Grinstead [:bgrins]
	Comment 2 • 10 years ago

(In reply to Jan Keromnes [:janx] from comment #0)
> When the DevTools theme is set to "Dark theme", the toolbox and the editors
> inside it are dark.
> 
> This doesn't look good with the all-light WebIDE. Its menus, panels and
> editors should become dark as well, making the "DevTools theme" setting work
> across all devtools.

FWIW this isn't true anymore - there is a force-theme attribute and Web IDE isn't ever using dark editors.  Point still stands that the editors (and the rest of the chrome) should respect the dark theme setting.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)
	Comment 3 • 9 years ago

Jan, Brian -

What's a good approach here?

Should we make all of WebIDE dark (editors and chrome)?

Should WebIDE have it's own theme toggle separate from the other tools?

	Brian Grinstead [:bgrins]
	Comment 4 • 9 years ago

It's a matter of implementing the dark theme on the remaining chrome in WebIDE that's the hard part.  It would take quite some work, and additionally we would need a lot of work from UX to move forward with this.  Here are the pieces that *could* be themed and whether or not I think it would be feasable to try and tackle them.

* file tree (yes)
* project summary page (yes)
* window chrome (no)
* Runtime / project popup (no)
* Preferences page / Manage extra components / Monitor pages (yes)

	Brian Grinstead [:bgrins]
	Comment 5 • 9 years ago

If we decided to do this, there should definitely be a toggle from the WebIDE preference UI, but that could be either:

1) a radio button that just toggles devtools.theme, and then the theme is always the same as the toolbox / devedition theme
2) a separate pref altogether

We are already sharing quite a few prefs between the WebIDE and toolbox, so I don't think 1 would be so bad, but we would want to get some UX / product feedback on that decision.

	Jan Keromnes [:janx] Reporter
	Comment 6 • 9 years ago

I agree that WebIDE should respect devtools.theme, especially for dev edition. A separate pref would be confusing and pointless, so option 1) sounds good to me.

In comment 4 I think you forgot to mention:
* code editor (yes)

It feels like WebIDE was left over during the browser restyling efforts of dev edition, and it's sad that so much work is involved in just making it consistent with the rest of the browser. I'm still amazed about the browser-wide dark theme, love it and use it in all my browsers :)

	Brian Grinstead [:bgrins]
	Comment 7 • 9 years ago

(In reply to Jan Keromnes [:janx] from comment #6)
> In comment 4 I think you forgot to mention:
> * code editor (yes)

Right, forgot to add that.  It's already pretty much done, we just need to remove the `themeSwitching: false` line from editors.js.

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 8 • 9 years ago

(In reply to Brian Grinstead [:bgrins] from comment #4)
> * Runtime / project popup (no)

Why do you think we shouldn't get these popups to respect the dark theme as well? Is it just not terribly easy or is it a ridiculous amount of work? I fear it would seem out of place with a dark window beneath.

	Brian Grinstead [:bgrins]
	Comment 9 • 9 years ago

(In reply to Panos Astithas [:past] from comment #8)
> (In reply to Brian Grinstead [:bgrins] from comment #4)
> > * Runtime / project popup (no)
> 
> Why do you think we shouldn't get these popups to respect the dark theme as
> well? Is it just not terribly easy or is it a ridiculous amount of work? I
> fear it would seem out of place with a dark window beneath.

I was assuming that the chrome window background (with the close/min/max buttons and runtime / app dropdowns) would be unchanged.  So even through the content behind it would be dark, the window itself that's opening the popup would be light.

FWIW we even have light popups for the dark devedition theme (which is being opened against dark chrome).  For reference of the amount of work it will take, I have a patch in bug 1090548 that makes most of the changes needed to theme the popups but needs some additional UI work for the hamburger and bookmarks popup IIRC.

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 10 • 9 years ago

Oh, I was assuming the chrome window background would indeed change, otherwise it would definitely not be an issue.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)
	Comment 11 • 9 years ago

We are planning to move back into a tab due to user feedback (bug 1110216).  Also, we are moving away from the XUL popups to HTML sidebars (bug 1079347).

These changes may make it easier to do some of the themeing discussed here.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)
	Comment 12 • 7 years ago

WebIDE is slated for removal (bug 1314811), so there are no plans to add to the current set of features.