Closed Bug 1046791 Opened 10 years ago Closed 10 years ago

Replace shared/elements/gaia_header with external component

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wilsonpage, Assigned: wilsonpage)

References

Details

Attachments

(1 file)

      No description provided.
Attached file pull-request (master) (deleted) —
Yan, I'm going to land the gaia-header shared stuff in this bug so we're not dependant on the Video patch landing as it seems to be taking longer than I thought.

Could you give this a quick check and then we can land it to make our lives a bit easier :)
Attachment #8465564 - Flags: review?(yor)
Blocks: 1015249
Comment on attachment 8465564 [details]
pull-request (master)

Looks fine.  I assume this is just a bower installed checkin and that any changes should still be done in gaia-components/gaia-header.
Attachment #8465564 - Flags: review?(yor) → review+
Landed on 'master'

https://github.com/mozilla-b2g/gaia/commit/0902a335ff297faf5eae18b6759876a7f7ec0693
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
yan: Now that this has landed, we can remove the dependency on the Video patch for each of the apps, rebase against master and begin to land stuff. NI just to confirm this is cool with you?
Flags: needinfo?(yor)
Great!  I'll get right to it next week (on vacation this week).
Flags: needinfo?(yor)
Depends on: 1054794
Depends on: 1054797
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: