Closed
Bug 1054797
Opened 10 years ago
Closed 9 years ago
GaiaIcons directory is wrongly named
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
Attachments
(1 file)
Our coding standards dictate lowercase_and_underscored filenames. We unfortunately do not yet have a linter for this, but as these components are new, we should strive to follow the convention.
The gaia-icons folder should be renamed to gaia_icons.
Assignee | ||
Comment 1•10 years ago
|
||
Hey Yan, Wilson,
We need to fix these directory paths. Could one of you guys review it? Thanks!
Attachment #8474280 -
Flags: review?(yor)
Attachment #8474280 -
Flags: review?(wilsonpage)
Comment 2•10 years ago
|
||
Comment on attachment 8474280 [details]
Github pull request
kgrandon: It isn't that simple I'm afraid, Bower names these directories, not us. The name is derived from the repo/package name.
It will be far to disruptive to rename the repo/package at this stage, and offers little benefit. It would be a lot easier for us to rename the the other directories in shared/elements/ to use the '-' style, and be the exception to the rule.
This is partly why I wanted to have a designated 'third-party external components' directory, that wasn't linted or tested inside the Gaia project. Having internal and external components in the same directory is confusing.
Attachment #8474280 -
Flags: review?(yor)
Attachment #8474280 -
Flags: review?(wilsonpage)
Attachment #8474280 -
Flags: review-
Assignee | ||
Comment 3•9 years ago
|
||
This work isn't important anymore.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•