Closed Bug 1052465 Opened 10 years ago Closed 10 years ago

[User Story] Hide SIM icon in status bar when no SIM present

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog, b2g-v2.1 verified, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S4 (12sep)
Project Flags:
tracking-b2g backlog
Tracking Flags:
Tracking Status
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: pdol, Assigned: apastor)

References

Details

(Keywords: feature, Whiteboard: [ucid:System250], [ft:systemsfe])

User Story

As a user I don't want an empty SIM icon in my status bar taking up space that could be used for other icons. 

Acceptance Criteria:
1. When two SIMs are inserted, both connectivity icons are shown, based on the regular status bar priority algorithm.
2. When only one SIM is inserted, only one icon shows, pertaining to that SIM card.
3. When no SIMs are inserted, only one empty SIM slot icon is shown.

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23740
(deleted), text/x-github-pull-request
mikehenrty
: review+
rmacdonald
: ui-review+
fabrice
: approval-gaia-v2.1+
Details
No description provided.
Note that in acceptance criteria 3, a SIM number shouldn't be shown.
Assignee: nobody → gmarty
Let's have Eli take a look at this one instead.
Assignee: gmarty → eperelman
Blocks: 996044
Status: NEW → ASSIGNED
Redirecting to Alberto, since he hates airplane movies.
Assignee: eperelman → apastor
Note that the SIM card status is not being updated when changing them (I'll file a bug for that), so you need to restart for testing the different cases.
Attachment #8484522 - Flags: ui-review?(rmacdonald)
Actually, after talking to Kevin, it seems that changing the SIM card without removing the battery is not expected/supported, so restarting is needed
Target Milestone: --- → 2.1 S4 (12sep)
(In reply to Alberto Pastor [:albertopq] from comment #5) > Actually, after talking to Kevin, it seems that changing the SIM card > without removing the battery is not expected/supported, so restarting is > needed Just flagging Peter to confirm. We may need to raise this as a separate requirement.
Flags: needinfo?(pdolanjski)
Comment on attachment 8484522 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23740 Thanks for taking care of this Alberto... From the UX perspective, this is a critical 2.1 feature as it eliminates the persistent display of an unused SIM slot and allows us to display an extra indicator when the search input field is present in portrait mode. - Rob
Attachment #8484522 - Flags: ui-review?(rmacdonald) → ui-review+
Attachment #8484522 - Flags: review?(mhenretty)
Comment on attachment 8484522 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23740 Approach looks reasonable enough to me. However, I think we should move the logic into the updateConnectionsVisibility() rather than the update.signal function. This both feels more semantically appropriate, and makes sure this will run when we finishInit the statusbar. Also, I'd like to see some tests for this.
Attachment #8484522 - Flags: review?(mhenretty)
Comment on attachment 8484522 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23740 Ammended the comments and added unit tests.
Attachment #8484522 - Flags: review?(mhenretty)
Comment on attachment 8484522 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23740 LGTM, thanks!
Attachment #8484522 - Flags: review?(mhenretty) → review+
master: https://github.com/mozilla-b2g/gaia/commit/8746bc86466677c3e1ed019c58c288577017362e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8484522 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23740 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): new feature [User impact] if declined: The statusbar might not have enough space for acommodating the rocketbar (996044,1056379) [Testing completed]: Manual tests + added unit tests. [Risk to taking this patch] (and alternatives if risky): The fix is pretty simple. Low risk of regressions. [String changes made]: -
Attachment #8484522 - Flags: approval-gaia-v2.1?(fabrice)
Attachment #8484522 - Flags: approval-gaia-v2.1?(fabrice) → approval-gaia-v2.1+
Verified the issue is fixed on 2.2. and 2.1 SIM icon in status bar is hide when no SIM present Device: Flame 2.2 Master KK BuildID: 20141030040201 Gaia: 0dfc1996eb583c8b507a82bf6b8319624bba23ea Gecko: 80e18ff7c7b2 Gonk: 48835395daa6a49b281db62c50805bd6ca24077e Version: 36.0a1 (2.2 Master) Firmware: V188 User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0 Device: Flame 2.1 KK BuildID: 20141030001201 Gaia: 3e585d8be5e2dffc376f83313299c9b6d53c3db4 Gecko: b643d78a23c6 Gonk: 48835395daa6a49b281db62c50805bd6ca24077e Version: 34.0 (2.1) Firmware: V188 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v2.1: fixed → verified
status-b2g-v2.2: fixed → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
Flags: needinfo?(pdolanjski)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: