Bobby Holley (:bholley) Reporter
	Description • 10 years ago

Once nsDOMClassInfo is gone, we should be able to do this, which will significantly simplify the Xray code.

	Tom S [:evilpie]
	Comment 1 • 8 years ago

I tried returning opaque xrays instead of XPCWN x-rays. Seems like most failures are related to SpecialPowers, at least on Linux.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ccdd181a01a

	Peter Van der Beken [:peterv] Assignee
	Comment 2 • 8 years ago

Yeah, I noticed the same thing. We'll need to figure out a solution for SpecialPowers.C*.

	Florian Bender
	Comment 3 • 7 years ago

Feel free to unassign if you're no longer working on this.

	Boris Zbarsky [:bzbarsky]
	Comment 4 • 7 years ago

Note that this bug can't land until prerequisites land, and those are stalled at the moment...

	Tom S [:evilpie]
	Comment 5 • 6 years ago

I rebased the patch and pushed to try: https://treeherder.mozilla.org/#/jobs?repoa=try&revision=73e008eaa4592cfb49c4110bae15a1dfeef875e7&selectedJob=171205078. Looks pretty good, no more SpecialPowers failure.

	Boris Zbarsky [:bzbarsky]
	Comment 6 • 6 years ago

Peter, I think this should be able to land now...

	Bobby Holley (:bholley) Reporter
	Comment 7 • 6 years ago

There's also a ton of simplification and improvement that can happen once this goes (removing resolveNativeProperty, for one). I guess bug 1160757 tracks part of this, but we should make sure to sit down and go through the code to clean it up.

	Peter Van der Beken [:peterv] Assignee
	Comment 8 • 6 years ago

Ok, I'll get review and land this.

	Tom S [:evilpie]
	Comment 9 • 6 years ago

The correct try link is actually https://treeherder.mozilla.org/#/jobs?repo=try&revision=73e008eaa4592cfb49c4110bae15a1dfeef875e7&selectedJob=171207521 in case you want to pull the rebased patch.

	Tom S [:evilpie]
	Comment 10 • 6 years ago

Peter, is there anyhing that needs to be changed in the patch or should I just upload the rebased version? I kind of want to get to some of the follow up work now.

	Peter Van der Beken [:peterv] Assignee
	Comment 13 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=55bca9f0ee3186bda94a7efaf96f464b63879d31

	Peter Van der Beken [:peterv] Assignee
	Comment 14 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=87a53a3512da7278b85ecb3772f480b581642024

	Peter Van der Beken [:peterv] Assignee
	Comment 16 • 6 years ago

I think we could technically remove XrayWrapper<Base, Traits>::set/enumerate, but the same could be said about has/get and those are more complicated. So I'll file a separate bug about that.

	Peter Van der Beken [:peterv] Assignee
	Comment 17 • 6 years ago

This is just moving some code around (now that XrayWrapper doesn't use SandboxCallableProxyHandler anymore).

	Peter Van der Beken [:peterv] Assignee
	Comment 18 • 6 years ago

Just some stuff I stumbled upon while working on this.

	Boris Zbarsky [:bzbarsky]
	Comment 19 • 6 years ago

Comment on attachment 8983813 [details] [diff] [review]
Remove XPCWN Xrays

r=me

	Boris Zbarsky [:bzbarsky]
	Comment 20 • 6 years ago

Comment on attachment 8983835 [details] [diff] [review]
Remove XrayTraits' HasPrototype

>+      : Base(flags | WrapperFactory::IS_XRAY_WRAPPER_FLAG, true)

Maybe:

  /* aHasPrototype = */ true

?  

r=me

	Boris Zbarsky [:bzbarsky]
	Comment 21 • 6 years ago

Comment on attachment 8983836 [details] [diff] [review]
Move Sandbox proxy handlers out of XrayWrapper.h

r=me

	Boris Zbarsky [:bzbarsky]
	Comment 22 • 6 years ago

Comment on attachment 8983837 [details] [diff] [review]
Remove some unused XRayWrapper code

Nice catch.  Looks like I forgot to remove this in bug 1436276...

	Peter Van der Beken [:peterv] Assignee
	Comment 23 • 6 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0c9e69ee274daf9d6c6eb017a92b856b88c368e
Bug 1053271 - Remove XPCWN Xrays. r=bz.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3cd7e51e9913010024d318fa6b726f335e21c48f
Bug 1053271 - Remove XrayTraits' HasPrototype. r=bz.

https://hg.mozilla.org/integration/mozilla-inbound/rev/00275042e5174f27f4a7697326dfd4a2a1c6c854
Bug 1053271 - Move Sandbox proxy handlers out of XrayWrapper.h. r=bz.

https://hg.mozilla.org/integration/mozilla-inbound/rev/509dc862a71ad7fbdcd19a257877085a6b5d21b1
Bug 1053271 - Remove some unused XRayWrapper code. r=bz.

	Andrei Ciure[:aciure]
	Comment 24 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c0c9e69ee274
https://hg.mozilla.org/mozilla-central/rev/3cd7e51e9913
https://hg.mozilla.org/mozilla-central/rev/00275042e517
https://hg.mozilla.org/mozilla-central/rev/509dc862a71a