Andrew Halberstadt [:ahal] Reporter
	Description • 10 years ago

This doesn't strictly block bug 890116, but I think it would be cleaner if there was something that got defined in build configuration (as opposed to a mozconfig exporting some environment variables). This would make it easier to know things like "when do we need to upload the .gcno zip?"

It would also make it easier for devs to build with code-coverage enabled locally and would let us fail fast with unsupported compilers.

	Sylvestre Ledru [:Sylvestre]
	Comment 1 • 10 years ago

I can help with this one if you want.

	Andrew Halberstadt [:ahal] Reporter
	Comment 2 • 10 years ago

I tried and failed to get this working as I'm a build noob. I think this fails because the compiler options aren't getting set in nsprpub. I tried variations of this patch that also didn't work.

I may come back to this in the future, but for now it isn't strictly needed. Also if someone from the build team is opposed to this, feel free to resolve WONTFIX.

	Andrew Halberstadt [:ahal] Reporter
	Comment 3 • 10 years ago

(In reply to Sylvestre Ledru [:sylvestre] from comment #1)
> I can help with this one if you want.

Sure, if you know how to do this, that would be a great help!

	Joshua Cranmer [:jcranmer]
	Comment 4 • 10 years ago

(In reply to Andrew Halberstadt [:ahal] from comment #2)
> Created attachment 8473671 [details] [diff] [review]
> Add --enable-code-coverage configure option (not working)
> 
> I tried and failed to get this working as I'm a build noob. I think this
> fails because the compiler options aren't getting set in nsprpub. I tried
> variations of this patch that also didn't work.

HOST_LDFLAGS="--coverage" is in my patch, but that appears to be for Linux32 builds specifically (because NSPR considers that a cross-compile).

Likely, what's happening is that we reset the CFLAGS and CXXFLAGS for our subconfigures. You might try adjusting _SUBDIR_CFLAGS et al as well to fix NSPR.

	Andrew Halberstadt [:ahal] Reporter
	Comment 5 • 10 years ago

Thanks for the suggestion, I'm hitting a wall with this though. I tried adding --coverage to every *FLAGS variable I could think of and it still isn't working. I tried all of:
CFLAGS
OS_CFLAGS
_SUBDIR_CFLAGS
NSS_CFLAGS
NSPR_CFLAGS
HOST_CFLAGS

and their CXXFLAGS/LDFLAGS equivalents.

For now I'm just going to go with exporting the variables in the mozconfig. Hopefully someone who knows what they're doing can pick this up in the meantime.

	Marco Castelluccio [:marco]
	Comment 6 • 7 years ago

Bug 1380665 introduced a "--enable-coverage" option. It doesn't automatically set the compiler flags though, it's only needed to specify that a build is a coverage build.