Closed
Bug 1380665
Opened 7 years ago
Closed 7 years ago
Define MOZ_CODE_COVERAGE for the entire tree instead of individually in several moz.build files
Categories
(Testing :: Code Coverage, enhancement)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
We're currently adding MOZ_CODE_COVERAGE to DEFINES in several moz.build files throughout the tree, it would be better to just define it for the entire tree.
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
I had to remove MOZ_CODE_COVERAGE from old-configure.in, otherwise it would have been added to config twice. Here's a green try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6549b982544def517db9656cd4fe1c5d92ef4f20 The mozinfo.json contains correct info ("ccov" is true): https://public-artifacts.taskcluster.net/V4zpl-GWS4alC7XLuZfIXg/0/public/build/target.mozinfo.json.
Attachment #8886195 -
Attachment is obsolete: true
Attachment #8886195 -
Flags: review?(jmaher)
Attachment #8886296 -
Flags: review?(jmaher)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8886296 [details] [diff] [review] Patch Review of attachment 8886296 [details] [diff] [review]: ----------------------------------------------------------------- thanks!
Attachment #8886296 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/32aa8aa9330b Define MOZ_CODE_COVERAGE for the entire tree. r=jmaher
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/32aa8aa9330b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•