Dominic Kuo [:dkuo] Assignee
	Description • 10 years ago

Besides the player's logic, currently the music app put all the views logic together in music.js, for the first step on refactoring, we are splitting all these views into different modules and files so that music app is better manageable, and will be ready to go to the next refactoring step.

	Dominic Kuo [:dkuo] Assignee
	Comment 2 • 10 years ago

Jim,

This bug is phase 1 for music refactoring(Bug 1053677), and here comes the first patch, basically I did:

1. Split music.js, put them into new modules/files under ui and views folders.
2. Add App object to represent Music app itself.
3. Fix the music jshint errors(except metadata.js).

It's a huge patch but most of them are the original code from music.js, would you please review this? thanks!!!

	Jim Porter (:squib)
	Comment 3 • 10 years ago

Comment on attachment 8500334 [details]
patch

This looks pretty good. I have some comments on GitHub about various small issues.

You'll also need to update the patch, since it's bitrotted (there are a couple of changes from bug 841949 and some more from bug 841977). Thanks!

	Dominic Kuo [:dkuo] Assignee
	Comment 4 • 10 years ago

(In reply to Jim Porter (:squib) from comment #3)
> Comment on attachment 8500334 [details]
> patch
> 
> This looks pretty good. I have some comments on GitHub about various small
> issues.
> 
> You'll also need to update the patch, since it's bitrotted (there are a
> couple of changes from bug 841949 and some more from bug 841977). Thanks!

Thanks Jim!!! after I have addressed those issues and will rebase to the latest, then ask review from you again.

	Dominic Kuo [:dkuo] Assignee
	Comment 5 • 10 years ago

Comment on attachment 8500334 [details]
patch

Jim, I have updated my patch and basically I did:

1. Addressed the issues you mentioned on github.
2. Rebased to the master head.
3. Resolved the conflicts.

Would you please review this again? thanks!

	Dominic Kuo [:dkuo] Assignee
	Comment 6 • 10 years ago

Thanks Jim!

master: https://github.com/mozilla-b2g/gaia/commit/f3bb9e92ef540aeeb464ecb801dd867c42072cda