Description: The error messages that appear do not have any text. This occurs in the browser, hosted apps, and apps that bring the user to the browser. Some of the error messages that do not have text are "server not found", "unable to connect", and "no access to the internet right now". Repro Steps: 1) Update a Flame device to BuildID: 20140818040201 2) Disconnect from the internet 3) Launch browser and go to any page 4) Observe text on error pages Actual: There is no text on the error pages Expected: It is expected that error pages tell the user what the problem is Environmental Variables: Device: Flame 2.1 Master (319mb) BuildID: 20140818040201 Gaia: aa8aace12d65956dd9525da5dac66e0d3b28597f Gecko: 0aaa2d3d15cc Version: 34.0a1 (2.1 Master) Firmware: V123 User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0 Notes: strings, problem, airplane, wifi, wi-fi Repro frequency: 100% Link to failed test case: See attached: screenshot, logcat

This issue also occurs on 2.1 Flame (512), and 2.1 Buri. Environmental Variables: Device: Flame 2.1 Master (512mb) BuildID: 20140818040201 Gaia: aa8aace12d65956dd9525da5dac66e0d3b28597f Gecko: 0aaa2d3d15cc Version: 34.0a1 (2.1 Master) Firmware: V123 User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0 Device: Buri 2.1 Master BuildID: 20140818073016 Gaia: ba1992f2addc5a84afc2eab426f222a6bf2962ba Gecko: bf27e27c994d Version: 34.0a1 (2.1 Master) Firmware: v1.2device.cfg User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0 Result: Error messages do not have text. ------------------------------------------------------------------------ This issue does not occur on 2.0 Flame, 2.0 Buri, 1.4 Flame, and 1.4 Buri. Environmental Variables: Device: Flame 2.0 (319mb) BuildID: 20140818000201 Gaia: fb2dd31abed2803eb7ad67eb4c52abb48de1e0f7 Gecko: 09f7a7184c71 Version: 32.0 (2.0) Firmware Version: v123 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 Device: Flame 1.4 (319mb) Build ID: 20140818063007 Gaia: 21bec64497dc06a7f12071d573570ba8fea598ae Gecko: 07d78d0f9bef Version: 30.0 (1.4) Firmware Version: v123 User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0 Device: Buri 2.0 Build ID: 20140818063008 Gaia: 640ce38ca03f1e26a4524ff4215b8b3f7731e2f0 Gecko: 692c93509dc9 Version: 32.0 (2.0) Firmware Version: v1.2device.cfg User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 Device: Buri 1.4 BuildID: 20140818063007 Gaia: 21bec64497dc06a7f12071d573570ba8fea598ae Gecko: 07d78d0f9bef Version: 30.0 (1.4) Firmware: v1.2device.cfg User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0 Result: Error messages have text.

[Blocking Requested - why for this release]: This is a regression from 2.0 and important strings are missing so nominating 2.1?

Mozilla Central Regression Window: Last Working: Device: Flame Master Build ID: 20140805072639 Gaia: 19bf9795263e2ccc15d824a52ebf23c2670fa9b9 Gecko: 2aaedcdf69f6 Version: 34.0a1 (Master) Firmware Version: v123 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 First Broken: Device: Flame Master Build ID: 20140805074901 Gaia: e93780f9da8b34f370a4113abd4df9780d58e443 Gecko: 1aab16f74817 Version: 34.0a1 (Master) Firmware Version: v123 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Last Working Gaia First Broken Gecko: Issue does NOT reproduce Gaia: 19bf9795263e2ccc15d824a52ebf23c2670fa9b9 Gecko: 1aab16f74817 First Broken Gaia Last Working Gecko: Issue DOES reproduce Gaia: e93780f9da8b34f370a4113abd4df9780d58e443 Gecko: 2aaedcdf69f6 Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/19bf9795263e2ccc15d824a52ebf23c2670fa9b9...e93780f9da8b34f370a4113abd4df9780d58e443 B2G Inbound Regression Window: Last Working: Device: Flame Master Build ID: 20140804131728 Gaia: 19bf9795263e2ccc15d824a52ebf23c2670fa9b9 Gecko: 7f81be7db528 Version: 34.0a1 (Master) Firmware Version: v123 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 First Broken: Device: Flame Master Build ID: 20140804133226 Gaia: f58bb4c40abbebd9ff9b32fb2a39bf3f44340991 Gecko: 2be403f035f5 Version: 34.0a1 (Master) Firmware Version: v123 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Last Working Gaia First Broken Gecko: Issue does NOT reproduce Gaia: 19bf9795263e2ccc15d824a52ebf23c2670fa9b9 Gecko: 2be403f035f5 First Broken Gaia Last Working Gecko: Issue DOES reproduce Gaia: f58bb4c40abbebd9ff9b32fb2a39bf3f44340991 Gecko: 7f81be7db528 Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/19bf9795263e2ccc15d824a52ebf23c2670fa9b9...f58bb4c40abbebd9ff9b32fb2a39bf3f44340991 Possibly broken by bug 994370 or bug 1048359 Starting with bug 994370 - Zibi can you take a look?

That's regression from bug 994370. netError requires inline locales, so if we want to get rid of them, we need to figure out a solution for netError until we fix bug 444165. Taking.

The patch updates webapp-optimize to embed l10n resources in netError case and l10n.js to react to that. Stas, can you look at this?

Comment on attachment 8476914 [details] [diff] [review] bug1055328.diff Review of attachment 8476914 [details] [diff] [review]: ----------------------------------------------------------------- Yuren, can you take a look at this? From your perspective it mainly adds an option to inject the whole ab-CD.json to <head/> if data-no-fetch is set (only net_error).

Flod, we're moving resources out of system.properties to new net_error.properties

Comment on attachment 8476914 [details] [diff] [review] bug1055328.diff Actually, I'd prefer to get sr from yuren on the build changes. Stas is doing the review.

Comment on attachment 8476914 [details] [diff] [review] bug1055328.diff Review of attachment 8476914 [details] [diff] [review]: ----------------------------------------------------------------- This is much better from the semantic point of view. Thanks! r=me.

Comment on attachment 8476914 [details] [diff] [review] bug1055328.diff Patch looks good but we should have an integration test for it. so we can add an app into dev_apps like test-l10n-optimize, add this app into build/config/phone/apps-engineering.list and use |make build-test-integration| to verify the content in profile by build.test.js[1] to avoid regression. [1] https://github.com/mozilla-b2g/gaia/blob/master/build/test/integration/build.test.js#L366-L370

marked as sr- because if I just cancel superreview, it will looks like a patch which is ready to land with r+.

Comment on attachment 8476913 [details] pull request Added the test. Requesting review on the test :)

Comment on attachment 8476913 [details] pull request r=yurenju if nit is addressed, thanks!

Commit: https://github.com/mozilla-b2g/gaia/commit/19f485905496e6daaf8cca136d0ac2f856cfcb20 Merge: https://github.com/mozilla-b2g/gaia/commit/82df767ab641da98a02d45a168b4ff9096e1d7b4

L20n.js: https://github.com/l20n/l20n.js/commit/a80d69cd549c203348e5082d4c57146f6f153d2b p.s. I see some errors on TBPL with my checkin but verified that it is not the result of this patch: - For Gij: https://tbpl.mozilla.org/php/getParsedLog.php?id=47200832&tree=Gaia-Try&full=1 - bug 1046828 comment 43 - Gip and Gu errors show up before my checkin

This issue is verified fixed on the Flame 2.1 and 2.2 The error messages display properly without missing text. Flame 2.1 Device: Flame 2.1 KK (319mb) (Full Flash) BuildID: 20141012001201 Gaia: d18e130216cd3960cd327179364d9f71e42debda Gecko: 610ee0e6a776 Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf Version: 34.0a2 (2.1) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Flame 2.2 Device: Flame 2.2 Master KK (319mb) (Full Flash) BuildID: 20141012040203 Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab Gecko: 44168a7af20d Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf Version: 35.0a1 (2.2 Master) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 Flame 2.2 Device: Flame 2.2 Master KK (319mb) (Full Flash) BuildID: 20141012040203 Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab Gecko: 44168a7af20d Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf Version: 35.0a1 (2.2 Master) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0