Closed Bug 1056088 Opened 10 years ago Closed 10 years ago

Refactor mobilenetwork.js code

Categories

(Marketplace Graveyard :: Code Quality, defect, P3)

Product:
Marketplace Graveyard
Component:
Code Quality
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2014-09-02

People

(Reporter: mat, Assigned: mat)

References

Details

Clean up mobilenetwork.js to make it more readable and DRY. Stolen from https://github.com/mozilla/fireplace/pull/373.
Blocks: 1049908
Target Milestone: 2014-08-26 → 2014-09-02
Fixed in https://github.com/mozilla/fireplace/commit/c6ddc220afb700f4566a94e1c344bd32de7ccf68 STR: - Open Marketplace with a phone & various SIM cards, make sure your region & carrier is detected properly (look for carrier_sim, region_sim in debug page)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
I have an AT&T SIM card, for region_sim is displayed "us" but for carrier_sim is displayed "deutsche_telekom". I also have a Movistar SIM card, but the info is displayed correctly.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Yeah, for some reason we set the carrier to "deutsche_telekom" for all US SIM cards. We do that for some other regions as well, it's not a new issue. Can you open a new bug for that ?
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
(In reply to Mathieu Pillard [:mat] from comment #3) > Yeah, for some reason we set the carrier to "deutsche_telekom" for all US > SIM cards. We do that for some other regions as well, it's not a new issue. > Can you open a new bug for that ? Thank you Mathieu. I have filed Bug 1061716 for the issues described in comment 2. Verified as fixed in MP-stage on FF OS 1.3 (Inari) with Movistar SIM card. Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.