Andy McKay Reporter
	Description • 10 years ago

We'd like to be able to track how many people are using the fully packaged app in metrics. If we can determine that value in the app, can we please add it in our pings to google analytics?

	Andy McKay Reporter
	Comment 1 • 10 years ago

I think this is just a matter of sending a value in app.html, as opposed to yulelog/index.html. We should send as much information as we can, do we have a version or tag to send back as well. Which begs the question, do we have that?

	Andy McKay Reporter
	Comment 2 • 10 years ago

Sorry need info'ing dbialer in case there's a special variable to put this information in since he's the GA expert.

	Christopher Van Wiemeersch [:cvan]
	Comment 3 • 10 years ago

In your console you can run

    require('settings').package_version

to get the package version (if packaged). That gets set by the `make` command:

    https://github.com/mozilla/fireplace/blob/bf4f0cc7f/Makefile#L44
    https://github.com/mozilla/fireplace/blob/bf4f0cc7f/src/media/js/settings_package_prod.js

If you search for ":debug" we also show the `package_version` value there.

	David Bialer [:dbialer]
	Comment 4 • 10 years ago

I think we need to set a custom variable.  I think the next available custom variable is 15.  https://docs.google.com/a/mozilla.com/spreadsheet/ccc?key=0AqvoOaUZL-jwdDNnZ3Z1X1FFbWhFRHhZdEFSY0dLcVE&usp=drive_web#gid=8

I don't know the Universal Analytics method but in GA you would do this
Set Version on Load:

_gaq.push(['_setCustomVar',
index = 15,
name = 'PackageVersion',
value = xx,
opt_scope = 2]);  (Defines this is a session level variable)

https://developers.google.com/analytics/devguides/collection/gajs/gaTrackingCustomVariables

Gareth is the expert and included him here.

	Gareth Cull [:garethc]
	Comment 5 • 10 years ago

Hey David,

You can view all of our Custom Dimensions in the GA Admin, under Property > Custom Definitions > Custom Dimensions. Slot 15 is open and I have activated it for you.

I believe you'll want to pass this on the app view page with the other Custom Dimensions that are being passed there.

ga('send', 'pageview', {
  'dimension15':  AppType // where AppType is Packaged App or Hosted App
});

	scolville Assignee
	Comment 6 • 10 years ago

PR https://github.com/mozilla/fireplace/pull/671

	scolville Assignee
	Comment 7 • 10 years ago

David - are we tracking the version to resolve this bug or the type? (see gareth's comment above (comment 5)) 

The PR adds tracking for the version as per your comment (comment 4) and looks to match what's being done for tarako in bug 1008382 (Albeit they're using a different dimension there though).

	David Bialer [:dbialer]
	Comment 8 • 10 years ago

Version would be more useful and consistent with Tarako.  Using version, can we distinguish between Tarako packages and Fireplace packages?  Also, could we set something like version 0 for website?

	scolville Assignee
	Comment 9 • 10 years ago

(In reply to David Bialer [:dbialer] from comment #8)
> Version would be more useful and consistent with Tarako.  Using version, can
> we distinguish between Tarako packages and Fireplace packages?  Also, could
> we set something like version 0 for website?

Yep - I've updated the code to set dimension15 to 0 when there's no package version.

	scolville Assignee
	Comment 10 • 10 years ago

https://github.com/mozilla/fireplace/commit/540a85eacb4dfc30a2dd58f88d490275f62c75f8

	David Durst [:ddurst]
	Comment 11 • 10 years ago

Since I've been discussing this in other channels with Mat and Gareth and David, may as well resolve all things here.

If dimension15 is going to be used for package version (or 0 if hosted) and can therefore be used to discern between packaged and hosted, that same dimension is fine for Tarako (which is only packaged, and is setting a build-id in dimension15 currently).

Since Tarako is identified by OS/Browser/BrowserVersion, dimension15 is useful and meaningful for us there as well -- but it's not how we identify Tarako.

So what I'd like to know is if it's OK to keep using dimension15 for Tarako, since it's effectively the same thing.

	scolville Assignee
	Comment 12 • 10 years ago

I spoke to David B and we should use 15 for this and Tarako.

	David Durst [:ddurst]
	Comment 13 • 10 years ago

We did a test today with Gareth where we searched for values of custom dimension 15 [https://www.google.com/analytics/web/?hl=en#my-reports/UsLv-lLXSPaQEpiOQyHwzA/a36116321w65336229p74912330/%3F_u.date00%3D20140901%26_u.date01%3D20141002/] and found nothing but zeroes. This was after verifying the View (marketplace-dev) was responding correctly. This means that, though the code looks correct (and straightforward), something is not right.

If anyone wants to install the package from marketplace-dev.allizom.org on a Flame and prove me wrong, I heartily support it.

	scolville Assignee
	Comment 14 • 10 years ago

(In reply to David Durst [:ddurst] from comment #13)
> We did a test today with Gareth where we searched for values of custom
> dimension 15
> [https://www.google.com/analytics/web/?hl=en#my-reports/UsLv-
> lLXSPaQEpiOQyHwzA/a36116321w65336229p74912330/%3F_u.date00%3D20140901%26_u.
> date01%3D20141002/] and found nothing but zeroes. This was after verifying
> the View (marketplace-dev) was responding correctly. This means that, though
> the code looks correct (and straightforward), something is not right.
> 
> If anyone wants to install the package from marketplace-dev.allizom.org on a
> Flame and prove me wrong, I heartily support it.

When testing this was package version set under :debug?

	David Durst [:ddurst]
	Comment 15 • 10 years ago

Indeed, it is not set, and ngoke confirmed that what I was testing was in fact the packaged iframe (so, no value expected).

Will test on a build of the real packaged app.

	scolville Assignee
	Comment 16 • 10 years ago

(In reply to David Durst [:ddurst] from comment #15)
> Indeed, it is not set, and ngoke confirmed that what I was testing was in
> fact the packaged iframe (so, no value expected).
> 
> Will test on a build of the real packaged app.


OK, I'll mark this as fixed again, and let you re-verify.

	David Durst [:ddurst]
	Comment 17 • 10 years ago

Verified as working in tarako packaged app, so I expect this to remain (as it was) fixed.