Closed Bug 1059843 (non-standard-js) Opened 10 years ago Closed 7 years ago

Stop using non-standard SpiderMonkey extensions in Thunderbird JS code [meta]

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jcranmer, Unassigned)

References

(Depends on 1 open bug)

Details

(Keywords: meta)

The things I saw most recently as being investigated for removal: * Old style generators (yield in non-function*, Iterator) * for each loops (Might [x for (x of arr)] instead of [for (x of arr) x] be involved as well?)
Bug 1054630 has a better list of extensions: * destructuring for-in * for-each * legacy generator * expression closures [I think this is function () x ?]
Alias: non-standard-js
Blocks: 867617
Depends on: 1118263
There's also let blocks: <https://dxr.mozilla.org/comm-central/search?q=regexp%3A%22let\s*\%28%22+-path%3Amozilla&case=true>. Interestingly, of the 11 uses, 3 of them seem to be copy-paste clones.
Depends on: 1117060
We have a ton of for..in usage with fixIterator(). Do you know how to rewrite that function so it can be used with for..of? Should I file that bug?
OS: Linux → All
Hardware: x86_64 → All
Actually it is already the bug 824104. Could you help there?
(In reply to :aceman from comment #3) > We have a ton of for..in usage with fixIterator(). Do you know how to > rewrite that function so it can be used with for..of? Should I file that bug? I have a prototype patch that should make fixIterator simultaneously usable with for..in and for..of.
Depends on: 1123117
Depends on: 1123118
Depends on: 1123119
Depends on: 1123122
Depends on: 1123124
Keywords: meta
Summary: Stop using non-standard SpiderMonkey extensions in Thunderbird JS code → Stop using non-standard SpiderMonkey extensions in Thunderbird JS code [meta]
Depends on: 1121727
The platform already removed JavaScript versions.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.