Remove the non-standard Iterator usage to allow better usage of external javascript tools like code validators, and to prevent potential bustage. This bug is about leftover from |for| loops seen while checking for |for ... in| destructuring. DXR url: https://dxr.mozilla.org/comm-central/search?q=regexp%3Afor\s*\%28%28var|let%29%3F\s%2B\%5B&case=true&redirect=true

Let's start with the tests. Successful Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=03c34a3d2365

Comment on attachment 8549238 [details] [diff] [review] /mail/test, v2 Review of attachment 8549238 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin

Great work cleaning these up! But I assume the changes in test-iteratorUtils.js here are bitrotted due to bug 1123117. Can you refresh the patch? Other than that, is this ready for check in? Or are the more patches to upload?

Any news?

Iterator() was removed in m-c (bug 1098412) and we adapted c-c to no longer use it (bug 1395116). It may be the code that this patch fixes is no longer there. As the patches didn't land 3 years ago, they need an overhaul now. Aryx?